Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear what happens if client_id_scheme appears twice #29

Closed
OIDF-automation opened this issue Jul 11, 2023 · 5 comments · Fixed by #263
Closed

Unclear what happens if client_id_scheme appears twice #29

OIDF-automation opened this issue Jul 11, 2023 · 5 comments · Fixed by #263
Labels
Milestone

Comments

@OIDF-automation
Copy link

Imported from AB/Connect bitbucket: https://bitbucket.org/openid/connect/issues/1982

Original Reporter: oliver-terbu

Clarify why client_id_scheme is needed in the request and in the Verifier Metadata. If this is by design, we need to clarify what happens in case both are present and potentially different.

@OIDF-automation
Copy link
Author

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

my understanding has been that client_id_scheme in the verifier metadata is supposed to be the schemes supported by the verifier vs client_id_scheme in the request is supposed to be which one verifier is using in that specific transaction. so i am pretty surprised to see the below definition in the verifier metadata:

client_id_scheme: OPTIONAL. JSON String identifying the Client Identifier scheme. The value range defined by this specification is pre-registered, redirect_uri, entity_id, did. If omitted, the default value is pre-registered.

I would have imagined it is client_id_schemes and is an array.

cc:@{557058:cf344cf5-3085-4fd6-abb3-eaa88b0f0ab9}

@Sakurann Sakurann removed bug labels Feb 1, 2024
@Sakurann
Copy link
Collaborator

Sakurann commented Apr 3, 2024

probably good to resolve together with #124

@jogu
Copy link
Collaborator

jogu commented Sep 26, 2024

I think this issue is based on a misunderstanding, client_id_scheme is not present in the verifier metadata.

I think the confusion may have arisen because the section that defines client_id_scheme is titled "Verifier Metadata Management".

It feels like it should probably be renamed but I'm struggling to come up with a new name.

@danielfett
Copy link
Contributor

@jogu PR #263 changes the title of the section to "Client Identifier Scheme and Verifier Metadata Management"

@jogu
Copy link
Collaborator

jogu commented Sep 27, 2024

Oh, thanks Daniel, I missed that change. I'm still not sure 'metadata management' is quite right but it's an improvement and I think arguably fixes this issue.

@jogu jogu closed this as completed in #263 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants