Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add c++/c interface to core #4

Merged
merged 40 commits into from
Dec 4, 2023
Merged

Conversation

FGadvancer
Copy link
Member


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

FGadvancer and others added 30 commits December 4, 2023 14:02
move to export.go
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@kubbot
Copy link
Contributor

kubbot commented Dec 4, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md


I have read the CLA Document and I hereby sign the CLA


0 out of 3 committers have signed the CLA.
@FGadvancer
@yj12138
@CNCSMonster
You can retrigger this bot by commenting recheck in this Pull Request

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

sweep-ai bot commented Dec 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@FGadvancer FGadvancer merged commit 2f6226c into openimsdk:main Dec 4, 2023
2 of 3 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants