[REVIEW]: PFEIFER: Preprocessing Framework of Electrograms Intermittently Fiducialized from Experimental Recordings #472

whedon · 2017-11-27T15:54:16Z

Submitting author: @bzenger (Brian Zenger)
Repository: https://github.com/SCIInstitute/PFEIFER
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @CristianaCorsi
Archive: 10.5281/zenodo.1158651

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/b3c9a521d3f2a1bd924c8e6a81f9f8b3"><img src="http://joss.theoj.org/papers/b3c9a521d3f2a1bd924c8e6a81f9f8b3/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/b3c9a521d3f2a1bd924c8e6a81f9f8b3/status.svg)](http://joss.theoj.org/papers/b3c9a521d3f2a1bd924c8e6a81f9f8b3)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@CristianaCorsi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Conflict of interest

As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

I confirm that I read and will adhere to the JOSS code of conduct.

General checks

Repository: Is the source code for this software available at the repository url?
License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
Version: Does the release version given match the GitHub release (v1.0.0)?
Authorship: Has the submitting author (@bzenger) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

Installation: Does installation proceed as outlined in the documentation?
Functionality: Have the functional claims of the software been confirmed?
Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

I suggest to use in the Documentation, figures that describe exactly the windows that open when you run PFEIFER. For example, in Chapter 6, figure 6.1 shows a window slightly different from the DATA_ORGANIZATION window that opens when you run PFEIFER. In the window each section has a specific name and the BEAT PROPAGATION section includes six fields, not four as reported in the figure (Window Length is called Window Width; the fields #Beats before updating and # Beats for updating are missing as well as the flags “Include RMS for Autofiducializing”, “Local Fiducials”, “Update Templates”; and the button !Default Settings!). The design of the window is also different from the one reported in figure 6.1.
I also suggest to include in the Documentation the link to the tutorials available at: http://www.sci.utah.edu/software/pfeifer.html

Software paper

Authors: Does the paper.md file include a list of authors with their affiliations?
A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

The text was updated successfully, but these errors were encountered:

whedon · 2017-11-27T15:54:19Z

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @CristianaCorsi it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

whedon · 2017-11-27T15:54:20Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-27T15:54:21Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-27T15:54:30Z

PDF failed to compile for issue #472 with the following error: 

 /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/find.rb:43:in `block in find': No such file or directory (Errno::ENOENT)
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/find.rb:43:in `collect!'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/find.rb:43:in `find'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:49:in `find_paper_paths'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:32:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:75:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

whedon · 2017-11-27T15:54:31Z

PDF failed to compile for issue #472 with the following error: 

 /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/find.rb:43:in `block in find': No such file or directory (Errno::ENOENT)
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/find.rb:43:in `collect!'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/find.rb:43:in `find'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:49:in `find_paper_paths'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:32:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:75:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

Kevin-Mattheus-Moerman · 2017-11-27T16:00:27Z

@CristianaCorsi this is where the review takes place. The review is guided by the tick boxes at the top of this issue which you are able to tick. See our website and reviewer guidelines for more information. If you have comments or issues you want to report for the authors you can leave comments here. You can also post issues on the project repo and link to them here. Thanks you. Let me know if I can help with anything.

Kevin-Mattheus-Moerman · 2017-11-27T16:00:59Z

@CristianaCorsi could you provide an indication as to when you think you can complete this review? Thanks

Kevin-Mattheus-Moerman · 2017-11-27T16:03:18Z

@bzenger The initial paper generation did not complete. I am unsure about the error but it looks like it cannot find your paper file. Could you please rename the paper folder and paper file to paper and paper.md respectively? Thanks

bzenger · 2017-11-27T22:32:45Z

@Kevin-Mattheus-Moerman This should be updated now. Could we re-run the generation function?

Kevin-Mattheus-Moerman · 2017-11-28T16:11:55Z

@whedon generate pdf

whedon · 2017-11-28T16:12:14Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-28T16:12:58Z

https://github.com/openjournals/joss-papers/blob/joss.00472/joss.00472/10.21105.joss.00472.pdf

Kevin-Mattheus-Moerman · 2017-11-28T16:31:43Z

@bzenger that seems to have worked. Can you check if the affiliations are complete/correct in your article?

bzenger · 2017-11-29T02:28:19Z

@Kevin-Mattheus-Moerman I just updated the affiliations for clarifications. If you could have whedon run again that would be great! Thank you so much!

Kevin-Mattheus-Moerman · 2017-11-29T15:12:12Z

@whedon generate pdf

whedon · 2017-11-29T15:12:15Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-29T15:12:30Z

PDF failed to compile for issue #472 with the following error: 

 /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse': (tmp/472/paper/paper.md): mapping values are not allowed in this context at line 37 column 9 (Psych::SyntaxError)
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse_stream'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:327:in `parse'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:254:in `load'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:475:in `block in load_file'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `open'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `load_file'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon.rb:73:in `initialize'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:26:in `new'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:26:in `set_paper'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:37:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:75:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

wgood · 2017-11-29T17:43:22Z

@whedon generate pdf

whedon · 2017-11-29T17:43:43Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-29T17:43:54Z

PDF failed to compile for issue #472 with the following error: 

 /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse': (tmp/472/paper/paper.md): mapping values are not allowed in this context at line 38 column 8 (Psych::SyntaxError)
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse_stream'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:327:in `parse'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:254:in `load'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:475:in `block in load_file'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `open'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `load_file'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon.rb:73:in `initialize'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:26:in `new'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:26:in `set_paper'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:37:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:75:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

wgood · 2017-11-29T21:05:41Z

@whedon generate pdf

whedon · 2017-11-29T21:05:59Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-29T21:06:10Z

PDF failed to compile for issue #472 with the following error: 

 /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse': (tmp/472/paper/paper.md): did not find expected key while parsing a block mapping at line 2 column 1 (Psych::SyntaxError)
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:379:in `parse_stream'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:327:in `parse'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:254:in `load'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:475:in `block in load_file'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `open'
	from /app/vendor/ruby-2.3.4/lib/ruby/2.3.0/psych.rb:474:in `load_file'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon.rb:73:in `initialize'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:26:in `new'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/lib/whedon/processor.rb:26:in `set_paper'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:37:in `prepare'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-33e05183aa0d/bin/whedon:75:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `load'
	from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `<main>'

arfon · 2017-11-29T21:18:58Z

@bzenger - sorry for the unhelpful errors from @whedon. I've made some fixes to your paper YAML header that were obvious (to me 😄) problems: SCIInstitute/PFEIFER#24

whedon · 2017-11-30T22:40:41Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2017-11-30T22:41:04Z

https://github.com/openjournals/joss-papers/blob/joss.00472/joss.00472/10.21105.joss.00472.pdf

Kevin-Mattheus-Moerman · 2017-12-01T15:45:02Z

@arfon. Perhaps we can fix this by always starting the DOI link on a new line.

arfon · 2017-12-01T15:48:08Z

@arfon. Perhaps we can fix this by always starting the DOI link on a new line.

Perhaps. Not sure how we would do that though?

Kevin-Mattheus-Moerman · 2017-12-01T16:48:41Z

I've added some statements over at openjournals/whedon#14.

Kevin-Mattheus-Moerman · 2017-12-08T17:01:39Z

@CristianaCorsi how are you getting on? Let me know if I can help with anything.

CristianaCorsi · 2017-12-08T17:04:20Z

Hi. I downloaded all the material. I hope I will be able to provide the review in ten days. If I need help I will let you know. Thank you!

Kevin-Mattheus-Moerman · 2017-12-08T17:15:01Z

@CristianaCorsi thanks for the update! Our review guidelines are here and you can find the tick-boxes at the top of this issue. Thanks for your help reviewing!

Kevin-Mattheus-Moerman · 2018-01-08T16:22:40Z

@bzenger @CristianaCorsi Happy New Year! 🎉
@CristianaCorsi how are you getting on? Are you able to finalize the review process soon? Let me know if I can help with anything.

CristianaCorsi · 2018-01-22T17:04:43Z

Hi Kevin. I completed the review process. I checked all the flags in the checklist and added some comments to the Documentation section. In my opinion the paper should be accepted. Is the review process finalized or I need to upload some additional files? Do I need to apply some different label to this issue? Thank you! Cristiana Il 08/01/2018 17.22, Kevin Mattheus Moerman ha scritto:

…

@bzenger <https://github.com/bzenger> @CristianaCorsi <https://github.com/cristianacorsi> Happy New Year! 🎉 @CristianaCorsi <https://github.com/cristianacorsi> how are you getting on? Are you able to finalize the review process soon? Let me know if I can help with anything. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#472 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgVBg6ajVu7xOxAPXiCAJ4R1py0nrtNzks5tIkDSgaJpZM4Qr2eU>.

-- Cristiana Corsi, PhD, Associate Professor Department of Electric, Electronic and Information Engineering "Guglielmo Marconi" - DEI University of Bologna Via Risorgimento 2 - 40136 Bologna - Italy Via Venezia 52 - 47521 Cesena - Italy tel. +39 051 2093009 - +39 0547 339207

Kevin-Mattheus-Moerman · 2018-01-22T17:11:34Z

@ChristianaCorsi 🎉 excellent thanks for completing the review process. We will handle things from here on. Can you and @bzenger confirm the comments to the documentation have been implemented? Can you link to an issue (if an issue was used)?

bzenger · 2018-01-22T18:31:42Z

Hi Kevin, We just updated our documentation with some small changes. These were done over an email exchange not through any GitHub issue. Dr. Corsi will email you with the confirmation. Thanks! Brian

…

On Jan 22, 2018, at 10:11 AM, Kevin Mattheus Moerman ***@***.***> wrote: @christianacorsi 🎉 excellent thanks for completing the review process. We will handle things from here on. Can you and @bzenger <https://github.com/bzenger> confirm the comments to the documentation have been implemented? Can you link to an issue (if an issue was used)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#472 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdF4h-NS-c7f7SUyAa-Bu-AJ8NxNsPayks5tNMFHgaJpZM4Qr2eU>.

CristianaCorsi · 2018-01-23T08:37:29Z

All the comments to the documentation have been implemented. Brian, could you please update the DOC folder in the submission web site with this new file (now available on the server http://sci.utah.edu/devbuilds/pfeifer_docs/PfeiferDocumentation.pdf)? Thank you! Cristiana Il 22/01/2018 18.11, Kevin Mattheus Moerman ha scritto:

…

@christianacorsi 🎉 excellent thanks for completing the review process. We will handle things from here on. Can you and @bzenger <https://github.com/bzenger> confirm the comments to the documentation have been implemented? Can you link to an issue (if an issue was used)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#472 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgVBg6yr94HdduiWxJUlsPFtt7DvZTB5ks5tNMFHgaJpZM4Qr2eU>.

-- Cristiana Corsi, PhD, Associate Professor Department of Electric, Electronic and Information Engineering "Guglielmo Marconi" - DEI University of Bologna Via Risorgimento 2 - 40136 Bologna - Italy Via Venezia 52 - 47521 Cesena - Italy tel. +39 051 2093009 - +39 0547 339207

Kevin-Mattheus-Moerman · 2018-01-23T16:32:36Z

@bzenger can you respond to @CristianaCorsi 's comments?

bzenger · 2018-01-23T16:53:21Z

@Kevin-Mattheus-Moerman @CristianaCorsi the doc is updated in the github repo. Thanks!

bzenger · 2018-01-24T06:16:58Z

@Kevin-Mattheus-Moerman let us know if there is anything else you need us to do!

Kevin-Mattheus-Moerman · 2018-01-24T14:53:48Z

Okay it looks like we are all set here! 🚀 🎉
@bzenger At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? @arfon can then move forward with accepting the submission.
Thanks @CristianaCorsi for the review!

bzenger · 2018-01-24T16:01:20Z

@Kevin-Mattheus-Moerman is this all I need for that process?

Kevin-Mattheus-Moerman · 2018-01-24T16:07:49Z

Yes all set. @arfon will take it from here.

arfon · 2018-01-24T20:11:18Z

@whedon set 10.5281/zenodo.1158651 as archive

whedon · 2018-01-24T20:11:22Z

OK. 10.5281/zenodo.1158651 is the archive.

arfon · 2018-01-24T20:29:20Z

@CristianaCorsi - many thanks for your review here and to @Kevin-Mattheus-Moerman for editing this one ✨

@bzenger - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00472 ⚡️ 🚀 💥

whedon · 2018-01-24T20:29:23Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00472/status.svg)](https://doi.org/10.21105/joss.00472)

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html

whedon assigned Kevin-Mattheus-Moerman Nov 27, 2017

whedon added the review label Nov 27, 2017

whedon mentioned this issue Nov 27, 2017

[PRE REVIEW]: PFEIFER: Preprocessing Framework of Electrograms Intermittently Fiducialized from Experimental Recordings #446

Closed

Kevin-Mattheus-Moerman assigned Kevin-Mattheus-Moerman and CristianaCorsi and unassigned Kevin-Mattheus-Moerman Nov 27, 2017

CristianaCorsi added enhancement and removed enhancement labels Jan 22, 2018

arfon added the accepted label Jan 24, 2018

arfon closed this as completed Jan 24, 2018

whedon added published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. labels Mar 2, 2020

editorialbot mentioned this issue Feb 9, 2024

[PRE REVIEW]: fff_segmenter: A signal segmentation script for acoustic FFF fabrication data in MATLAB #5808

Closed

[REVIEW]: PFEIFER: Preprocessing Framework of Electrograms Intermittently Fiducialized from Experimental Recordings #472

[REVIEW]: PFEIFER: Preprocessing Framework of Electrograms Intermittently Fiducialized from Experimental Recordings #472

Comments

whedon commented Nov 27, 2017 • edited Loading

Status

Reviewer instructions & questions

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented Nov 27, 2017

whedon commented Nov 27, 2017

whedon commented Nov 27, 2017

whedon commented Nov 27, 2017

whedon commented Nov 27, 2017

Kevin-Mattheus-Moerman commented Nov 27, 2017

Kevin-Mattheus-Moerman commented Nov 27, 2017

Kevin-Mattheus-Moerman commented Nov 27, 2017

bzenger commented Nov 27, 2017

Kevin-Mattheus-Moerman commented Nov 28, 2017

whedon commented Nov 28, 2017

whedon commented Nov 28, 2017

Kevin-Mattheus-Moerman commented Nov 28, 2017

bzenger commented Nov 29, 2017

Kevin-Mattheus-Moerman commented Nov 29, 2017

whedon commented Nov 29, 2017

whedon commented Nov 29, 2017

wgood commented Nov 29, 2017

whedon commented Nov 29, 2017

whedon commented Nov 29, 2017

wgood commented Nov 29, 2017

whedon commented Nov 29, 2017

whedon commented Nov 29, 2017

arfon commented Nov 29, 2017 • edited Loading

whedon commented Nov 30, 2017

whedon commented Nov 30, 2017

Kevin-Mattheus-Moerman commented Dec 1, 2017

arfon commented Dec 1, 2017

Kevin-Mattheus-Moerman commented Dec 1, 2017

Kevin-Mattheus-Moerman commented Dec 8, 2017

CristianaCorsi commented Dec 8, 2017

Kevin-Mattheus-Moerman commented Dec 8, 2017

Kevin-Mattheus-Moerman commented Jan 8, 2018

CristianaCorsi commented Jan 22, 2018 via email

Kevin-Mattheus-Moerman commented Jan 22, 2018

bzenger commented Jan 22, 2018 via email

CristianaCorsi commented Jan 23, 2018 via email

Kevin-Mattheus-Moerman commented Jan 23, 2018

bzenger commented Jan 23, 2018

bzenger commented Jan 24, 2018

Kevin-Mattheus-Moerman commented Jan 24, 2018

bzenger commented Jan 24, 2018

Kevin-Mattheus-Moerman commented Jan 24, 2018

arfon commented Jan 24, 2018

whedon commented Jan 24, 2018

arfon commented Jan 24, 2018

whedon commented Jan 24, 2018

whedon commented Nov 27, 2017 •

edited

Loading

arfon commented Nov 29, 2017 •

edited

Loading