[REVIEW]: ShinySSD: Species Sensitivity Distributions for Ecotoxicological Risk Assessment #785
Comments
|
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @kylehamilton it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type: |
|
|
PDF failed to compile for issue #785 with the following error: /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/author.rb:36:in |
|
If there is something unclear in the submission I can improve it |
|
@flor14 the multiple affiliations need quoting. i.e. change this: to this in your |
|
done!
El jue., 12 jul. 2018 a las 14:53, Arfon Smith (<[email protected]>)
escribió:
… @flor14 <https://github.com/flor14> the multiple affiliations need
quoting. i.e. change this:
affiliation: 1,2
to this in your paper.md
affiliation: "1,2"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcPTagYe2_MHb_NCL-8LwalKkwUs1feHks5uF40HgaJpZM4UuY_T>
.
|
|
@whedon generate pdf |
|
|
Great.
Only one thing:
The citation that says "Plan protection Products" is not correct, I have
changed the bib file in order to modify that
Sorry about that and thank you
El jue., 12 jul. 2018 a las 16:25, whedon (<[email protected]>)
escribió:
… --> Check article proof 📄 <--
<https://github.com/openjournals/joss-papers/blob/joss.00785/joss.00785/10.21105.joss.00785.pdf>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcPTav4jcHrs32C9fghSzXsbrG8UXtbZks5uF6K7gaJpZM4UuY_T>
.
|
|
@kylehamilton Just wanted to check in on the status of your review. Are you waiting on @flor14 for any pending items? 🙏 |
|
I have not pending items yet
El lun., 30 jul. 2018 a las 17:13, Karthik Ram (<[email protected]>)
escribió:
… @kylehamilton <https://github.com/kylehamilton> Just wanted to check in
on the status of your review. Are you waiting on @flor14
<https://github.com/flor14> for any pending items? 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcPTaoeh0IbtuErsohha7yAhoRxle838ks5uL2j1gaJpZM4UuY_T>
.
|
|
Sorry for the delay I'll have this completed by the end of the day. |
|
Thanks @kylehamilton Let me know if you need any help. 🙏 |
|
I can help if something is confusing. |
|
Hello! I was thinking about this today. Is there something can I start improving? Thank you so much |
|
@kylehamilton Gentle ping to see if you are able to wrap your review soon? |
|
Hi @kylehamilton, checking in again to see if you've had time to wrap this review up. |
|
Sorry @karthik I posted the things that needed to be addressed in the issues of the repo https://github.com/flor14/paper/issues
If I did this wrong then I'm really sorry I thought that if I posted them as issues in the repo then it would move on from there. |
|
Thanks! I will do it soon
El lun., 24 sept. 2018 a las 16:44, W. Kyle Hamilton (<
[email protected]>) escribió:
… Sorry @karthik <https://github.com/karthik> I posted the things that
needed to be addressed in the issues of the repo
https://github.com/flor14/paper/issues
1. Make the software into an R package so everything would be
contained and centralized flor14/shinyssd#2
<flor14/shinyssd#2>
2. Add tests flor14/shinyssd#3 <flor14/shinyssd#3>
3. Just want to make sure that there is a DOI for the source code I
didn't see this in the .bib file or in the readme flor14/shinyssd#4
<flor14/shinyssd#4>
4. A minor change would in the name of the repo for production code
should be changed from paper to ShinySSD
5. Needs version numbers, shifting this to an R package would help fix
this flor14/shinyssd#6 <flor14/shinyssd#6>
6. I did not see community guidelines flor14/shinyssd#7
<flor14/shinyssd#7>
If I did this wrong then I'm really sorry I thought that if I posted them
as issues in the repo then it would move on from there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcPTaiQ4HmKyRPC06JMs9P7tp-uJHhb8ks5ueTY7gaJpZM4UuY_T>
.
|
|
I have completed the review. Thank you |
|
Thank you @flor14 🙏 |
|
@flor14 I noticed there are couple more issues to fix before we can proceed with this. Can you please address the last two issues (5/6) that Kyle raised. I'd like to wrap this up before the end of the year. Thanks. |
|
I will have a look a soon as possible. Thank you.
El lun., 19 nov. 2018 a las 16:56, Karthik Ram (<[email protected]>)
escribió:
… @flor14 <https://github.com/flor14> I noticed there are couple more
issues to fix before we can proceed with this. Can you please address the
last two issues (5/6) that Kyle raised. I'd like to wrap this up before the
end of the year. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcPTauZXsGrmncyEGCHeTuNrOEIl7VrMks5uwwztgaJpZM4UuY_T>
.
|
|
I completed what was missing from the last review. |
|
👋 @kylehamilton — the author states they have made changes addressing the issues you brought up in review. Could you have a look, and see if you can check off a few more items from the review checklist? If you are satisfied, we'll need a statement from you here saying you recommend publication. Thanks! 🙏 |
|
Hello. The last 4 months I have been finishing my PhD so I had no time to
check this (and I will not have until the last week of February). I am not
sure how is JOSS policy about timing, but I can test everything again and
make improvements on February. Sorry about this, it took a bit longer than
expected.
Regards
El sáb., 19 ene. 2019 a las 19:23, Lorena A. Barba (<
[email protected]>) escribió:
… 👋 @kylehamilton <https://github.com/kylehamilton> — the author states
they have made changes addressing the issues you brought up in review.
Could you have a look, and see if you can check off a few more items from
the review checklist? If you are satisfied, we'll need a statement from you
here saying you recommend publication. Thanks! 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AcPTauupddomfiULvTVMQVfaPA-eWWe6ks5vE5rdgaJpZM4UuY_T>
.
|
|
Hi @flor14, could you add full affiliation information as in a typical article (e.g., department, city, country)? Also, I made a small PR to fix a few things, if you could accept and merge that: flor14/shinyssd#9 |
|
I improved what you mentioned. If citations are ok, and subscripts are
correct in the second paragraph: " HC1, HC5 and HC10" for me it is ready.
Maybe citations could be more detailed in the author's guidelines?
Mentioning the 3 main cases:
1- @author:2001 -> author et al. (2001)
2- [@author:2001] -> (author et al. 2001)
3- [@author1:2001; @author2:2001] -> (author1 et al. 2001; author2 et al.
2002)?
I mention this just to save your time.
Thank you Kyle! You was very kind
El mié., 29 may. 2019 a las 16:40, Kyle Niemeyer (<[email protected]>)
escribió:
… Hi @flor14 <https://github.com/flor14>, could you add full affiliation
information as in a typical article (e.g., department, city, country)?
Also, I made a small PR to fix a few things, if you could accept and merge
that: flor14/shinyssd#9 <flor14/shinyssd#9>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785?email_source=notifications&email_token=AHB5G2RYJYQWRB46ZUJGMNLPX3L2PA5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQNVPI#issuecomment-497081021>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHB5G2XV5ECE2RUUBASW3CTPX3L2PANCNFSM4FFZR7JQ>
.
|
|
@flor14 yes, the citation documentation could be improved... I've had to fix this issue in a number of papers. |
|
@whedon generate pdf |
|
|
PDF failed to compile for issue #785 with the following error: Error producing PDF. Looks like we failed to compile the PDF |
|
@flor14 for the last subscript, I think you need to have |
|
I've changed subscripts to this now: $HC_1$, $HC_5$ and $HC_{10}$
The problem seems the last one with 2 digits
El mié., 29 may. 2019 a las 18:29, whedon (<[email protected]>)
escribió:
… PDF failed to compile for issue #785
<#785> with the
following error:
Error producing PDF.
! Double subscript.
l.316 ...estimators (HC_1), (HC_5) and (HC_1_
Looks like we failed to compile the PDF
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#785?email_source=notifications&email_token=AHB5G2THZKL5WNW32FH5HNTPX3YT5A5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQWH6Y#issuecomment-497116155>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHB5G2ULZLFHDGRQC433KKTPX3YT5ANCNFSM4FFZR7JQ>
.
|
|
@whedon generate pdf |
|
|
@whedon accept |
|
|
|
Check final proof 👉 openjournals/joss-papers#721 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#721, then you can now move forward with accepting the submission by compiling again with the flag |
|
@whedon accept deposit=true |
|
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
|
Congrats @flor14 on your submission's publication in JOSS! Thanks to @kylehamilton for reviewing and @karthik for editing! |
|
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets: This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon
added
published
Submitting author: @flor14 (María Florencia D'Andrea)
Repository: https://github.com/flor14/paper
Version: v1.0.0
Editor: @karthik
Reviewer: @kylehamilton
Archive: 10.5281/zenodo.3233033
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kylehamilton, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @karthik know.
Review checklist for @kylehamilton
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.mdfile include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: