Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto resize pvc when only expand volumeClaimTemplates in asts #1714

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Auto resize pvc when only expand volumeClaimTemplates in asts #1714

merged 1 commit into from
Sep 25, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Aug 28, 2024 •
edited
Loading

Ⅰ. Describe what this PR does

Auto resize pvc when only expand volumeClaimTemplates in asts

Ⅱ. Does this pull request fix one issue?

fixes #1699

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@ABNER-1 ABNER-1 changed the title resize Auto resize pvc when only expand volumeClaimTemplates in asts Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.19%. Comparing base (0d0031a) to head (2379fe1).
Report is 92 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/statefulset/stateful_set_control.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
+ Coverage   47.91%   49.19%   +1.27%     
==========================================
  Files         162      191      +29     
  Lines       23491    19600    -3891     
==========================================
- Hits        11256     9642    -1614     
+ Misses      11014     8701    -2313     
- Partials     1221     1257      +36
Flag Coverage Δ
unittests 49.19% <77.77%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1 ABNER-1 force-pushed the support-only-resize-vct-new branch from 002ac19 to 8da6211 Compare August 28, 2024 06:14
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Aug 28, 2024
@ABNER-1 ABNER-1 force-pushed the support-only-resize-vct-new branch from 8da6211 to 3415fed Compare August 28, 2024 06:56
@zmberg zmberg added this to the 1.8 milestone Sep 3, 2024
@zmberg
Copy link
Member

zmberg commented Sep 3, 2024

/lgtm

@kruise-bot kruise-bot added the lgtm label Sep 3, 2024
@furykerry furykerry merged commit 450dc5e into openkruise:master Sep 25, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furykerry furykerry furykerry approved these changes

Assignees

@zmberg zmberg

Labels
lgtm size/L size/L: 100-499
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

[feature request]When only resize VolumeClaimTemplates, asts should also resize pvcs
4 participants
@ABNER-1 @kruise-bot @zmberg @furykerry