Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InPlaceUpdateBackOff] In-place update pod should retry with a backoff. #1730

Open
veophi opened this issue Sep 9, 2024 · 0 comments
Open
Assignees

Comments

@veophi
Copy link
Member

veophi commented Sep 9, 2024

What would you like to be added:
Currently, in-place update loop:

1. update pod status condition`InPlaceUpdateReady=False`;
2. update pod spec & metadata, and record state in `apps.kruise.io/inpace-update-state`;
3. update pod status condition `InPlaceUpdateReady=True` if pod updated succeeded **or not-in-updating**.

But, we have a webhook to validate some pod fileds, and when we start a wrong update(e.g., update a invalid image), the step2 will return error, and the step 1&3 will always execute without backoff due to

, lots of events about pod ready changes "DDOS" our registration center.

Why is this needed:
In-place update should retry with a reaonable backoff when failed to update pod .

@veophi veophi assigned FillZpp and zmberg and unassigned FillZpp Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants