Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] workloadspread 支持 cr 给 pod 打 pod-deletion-cost 标 #1744

Open
ermazi opened this issue Sep 13, 2024 · 5 comments
Open

Comments

@ermazi
Copy link

ermazi commented Sep 13, 2024

ws === workloadspread
pdc === pod-deletion-cost

What would you like to be added:
cr 支持打 pdc 标
Why is this needed:
ws 依赖 pdc ,现在 ws 不支持给 cr 打 pdc 标, 缩容没法保证 pod 满足约束

求支持:DDDD

@furykerry
Copy link
Member

workloadspread can only annotate related pods with deletion cost, but workloadspread cannot guarantee that the actual deletion sequence which is controlled by the controller behind the customized resource

@ermazi
Copy link
Author

ermazi commented Sep 13, 2024

workloadspread can only annotate related pods with deletion cost, but workloadspread cannot guarantee that the actual deletion sequence which is controlled by the controller behind the customized resource

Just need annotate pods. As for whether CR supports the pod-deletion-cost feature, that's CR's responsibility.

@ermazi
Copy link
Author

ermazi commented Sep 13, 2024

比如我们的场景, cr 控制 多个 dp, versionedmap就是 pod-template-hash -> pod 的映射; 获取最新版本, 就通过 cr 的status 字段, 获取当前最新版本呢, 然后 ref查到 dp, 再找到 rs , 获取最新的 rs pod-template-hash 作为最新版本, 从而进行 pdc 打标
--trans--
For example, in our scenario, the CR controls multiple DP, and the VersionedMap is the mapping from pod-template-hash to pods. To get the latest version, you would check the status field of the CR to find the current latest version, then use the reference to locate the DP, and from there find the RS. Obtain the latest pod-template-hash from the newest RS as the latest version, and then proceed with PDC labeling.

Copy link

stale bot commented Dec 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 21, 2024
@furykerry furykerry removed the wontfix This will not be worked on label Dec 23, 2024
@furykerry
Copy link
Member

sorry for the late reply. what do you mean patch PDC to CR ? If you mean patch the pod managed by CR, then you can checkout this feature. and if you have further question, can you attend the recent biweekly meeting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants