Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table A11y updates #4055

Open
3 tasks done
StephDriver opened this issue Mar 22, 2024 · 4 comments · May be fixed by #4490
Open
3 tasks done

Table A11y updates #4055

StephDriver opened this issue Mar 22, 2024 · 4 comments · May be fixed by #4490
Assignees
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. priority-high High priority size XL Extra large VPAT Issue prioritised for VPAT improvements.

Comments

@StephDriver
Copy link
Contributor

StephDriver commented Mar 22, 2024

  • review use of tables across platform

From #4194 the following issues have been identified:

  • Tables do not consistently have <th> tags for both rows and columns. This occurs in both tables that are part of the main template for the page, e.g. article dates shown on the material theme, and for tables within articles themselves.
  • footnotes within the tables that are to be written under the table, rather than as endnotes are not working well.

Part of the problem here is that JATS allows for inaccessible tables to be specified, thus user content will not always produce accessible tables. The row/column headings should be specified in the JATS and then picked up so if it is not correct there, it won't be correct on the page either.

Therefore we should -

  • ensure non-article (i.e. non user content) tables are accessible. Each data cell is expected to be understood in the context of one column header and one row header - so a single row of headers and a single column of headers for each table, using the <th> tag.
  • add user content/jats issue to Phase 2 of A11y project.
@StephDriver StephDriver converted this from a draft issue Mar 22, 2024
@StephDriver StephDriver changed the title Accessible Tables Table A11y Audit Mar 22, 2024
@StephDriver StephDriver self-assigned this Mar 22, 2024
@StephDriver StephDriver moved this from Todo to Next in Accessibility Mar 22, 2024
@StephDriver StephDriver added this to the A11y Phase 1 milestone Apr 10, 2024
@StephDriver StephDriver added the a11y Issues that relate to acessibility label Apr 10, 2024
@StephDriver StephDriver moved this from Scheduled to Triage in Accessibility Apr 12, 2024
@StephDriver
Copy link
Contributor Author

StephDriver commented Jun 3, 2024

from Screen reader testing (#4194):

  • Sample 2, item 66. dates are given in a table. This has no column header. I suggest "Date" as the header, or not to use tables here.
  • Sample 4, item 33. table does not have unique headers for rows and columns, and what row headers exist, are only shown visually with <strong> tags rather than <th>
  • Sample 4, item 35. following footnotes inside the table (e.g. in table 7) link to footnotes by moving the page on the screen, but reading or tabbing onwards takes you back to the original location, so footnote cannot be read.
  • Sample 4, item 36. table footnotes do not have the letter of the footnote to which they relate.
  • Sample 4, item 37. table footnotes are in paragraphs, rather than as a list.

@StephDriver StephDriver changed the title Table A11y Audit Table A11y updates Jun 3, 2024
@StephDriver StephDriver moved this from Triage to Sent to Dev in Accessibility Jun 4, 2024
@StephDriver StephDriver moved this from Sent to Dev to Triage in Accessibility Jun 27, 2024
@StephDriver
Copy link
Contributor Author

https://jats4r.niso.org/accessibility/
JATS table a11y

@StephDriver StephDriver moved this from Triage to Needs Investigation in Accessibility Jun 27, 2024
@StephDriver StephDriver added the VPAT Issue prioritised for VPAT improvements. label Jun 27, 2024
@StephDriver
Copy link
Contributor Author

I have started going through the codebase to work out what tables we have and what kind of updates might be needed. I think for the majority, I have the information needed to make updates, so I'd like to move this to Dev Ready and continue working on it there - might as well make changes as I review rather than report my findings only to have to go through them all again to make updates. It is possible some tables will be missed, but this should address the majority, and any outliers could be picked up later as individual fixes.

For info:

I have found 211 tables that need reviews.

Having taking an initial look at the first 24 tables:

  • 8 tables with empty cells
  • 8 tables with merged cells
  • 1 table with a header marked as td
  • 7 tables that have passed the first review that was just looking for obvious issues.

From this I believe that even if I only fix the obvious stuff, it would make a big difference.

@StephDriver StephDriver moved this from Needs Investigation to Sent to Dev in Accessibility Aug 23, 2024
@joemull joemull added dev-ready This issue has been refined and is ready for development. size XL Extra large priority-high High priority labels Aug 29, 2024
@StephDriver StephDriver linked a pull request Nov 14, 2024 that will close this issue
@StephDriver
Copy link
Contributor Author

Working on tables within themes directory only, and using W3C Tables Tutorial for guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. priority-high High priority size XL Extra large VPAT Issue prioritised for VPAT improvements.
Projects
Status: Sent to Dev
2 participants