Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify: dedicated disk handling #571

Open
johnarwe opened this issue Dec 30, 2021 · 3 comments
Open

Clarify: dedicated disk handling #571

johnarwe opened this issue Dec 30, 2021 · 3 comments

Comments

@johnarwe
Copy link
Member

POST /guests allows a list of dedicate_vdevs when creating a guest. The associated request sample omits it, so the format of each entry is ambiguous (string? dict?). DirMaint 7.2's DIRM DEDICATE command documentation suggests that a system device name (rdev or volid) is minimally required for each dedicated device, unless this API carries an implicit assumption that the corresponding directory entry statements would be populated out of band (I find zero other mentions of "dedicated" in the entire REST API doc page).

It's also unclear how any dedicated devices would behave if their vdevs are included on the 3 /guests/{userid}/disks method calls. Presumably (by omission) Feilong does not support adding dedicated disks after the guest is created. Modify and delete might apply regardless of how the disk was created, however.

@johnarwe
Copy link
Member Author

Attach volume and the corresponding Detach API might also figure into this issue. If Attach-volume, for example, adds a DEDICATE statement in the directory entry and/or runs CP ATTACH rdev guest vdev.

@jichenjc
Copy link
Collaborator

attach volume is only focus on FCP now, which is DEDICATE XXXX XXXX
while the XXXX is the FCP number ...

@jichenjc
Copy link
Collaborator

I don't remember we have dedicate_vdevs for ECKD disk use case, so for ECKD from dasd group
we use MDISK XXX to represent and for persistent storage, DEDICATE XXXX XXXX is used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants