Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] typo in DataEntryBuilder.java, getFiled() should getField() #33

Open
imaffe opened this issue Mar 25, 2020 · 1 comment
Open

Comments

@imaffe
Copy link

imaffe commented Mar 25, 2020

I found a place that is likely a typo. But I found it is used widely in downstream projects, fixing this requires a typo fix tool and some planning. Should we consider fixing it now or put it for a later refactoring?

// wondering putField() would make more sense
    public DataEntryBuilder putFiled(String fieldName, Object value) {

        Field field = lookupField(fieldName);
        payload[field.getIndex()] = value;
        return this;
    }
@vongosling
Copy link
Contributor

Yes, Could you help to pr it :-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants