Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ConnectRecord api #47

Open
sunxiaojian opened this issue Jun 11, 2022 · 0 comments
Open

Optimize ConnectRecord api #47

sunxiaojian opened this issue Jun 11, 2022 · 0 comments

Comments

@sunxiaojian
Copy link
Contributor

sunxiaojian commented Jun 11, 2022 •
edited
Loading

问题如下：

  1. 建议拆分 SinkRecord 和 SourceRecord， 语义明确，方便区分数据执行阶段，同时方便两部分api独立扩展，以防止出现有些字段在 source中用到，却在 sink中用不到但依然存在的情况，容易对使用上带来疑惑，造成过多的沟通的成本；
  2. 显式声明topic / offset / queueId等字段，放到 recordPartition中用map 方式存储，结构较深，且对不熟悉代码的人不易发觉，学习成本较高，且导致代码过于松散
  3. Record 绑定 topic, 方便多topic路由发送
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue Jun 22, 2022
@sunxiaojian
Optimize ConnectRecord api openmessaging#47
5de17b2
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue Jul 13, 2022
@sunxiaojian
Optimize ConnectRecord remove queueId field openmessaging#47
e94593e
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue Jul 20, 2022
@sunxiaojian
merge new features openmessaging#47
7036d48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunxiaojian