-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Ordering of fleet-related policies #771
Comments
/cc @marie-x WDYT? What was the original intention when authoring |
@schnuerle @marie-x any plans to tackle fleet policies in MDS 2.0? |
Let's see what @jean-populus and @S-eb think about clarifying this as part of the Policy work for 2.0, since they have been leading this work on the steering committee. |
This is a pretty big change so I'm not sure we'd have time to solicit feedback and come up with a solution in time for this version. But let's add this for consideration for v3. |
Is this still a need @mrsimpson? If so maybe you can draft a PR off of MDS 2.0? If it's a breaking change we can try to line it up for 3.0. |
@schnuerle I still see this as open and unclear wrt how the policy evaluation shall work. |
Ok we will keep it open and hopefully get support from others on creating a PR. |
Need for clarification
in the policy spec, it is quite clearly described that ordering of rules within a policy is used to model precedence of one rule over the other.
While this is comparatively easy to understand for policies addressing an individual device (
time
andspeed
rules), this is not intuitive for policies addressing an operators fleet (count
): If a policy defines two rules, providers can violate both with the same fleet at the same time – and I'd expect both violations to be reported.A quick example (illustrative):
Although a provider may comply to the first rule and not flood down town with vehicles, there could still be too many devices within the whole district.
Describe the solution you'd like
I'd expect all rules with type
count
to be evaluated within a policy – and not interrupt the assessment after the first match.Is this a breaking change
Currently, there is no explicit information about handling count-based policies/rules, but there is general precedence included in the spec, so I'd judge this
Impacted Spec
For which spec is this feature being requested?
policy
Describe alternatives you've considered
We could also split up count rules into own policies. However, this would make it more tricky to lifecycle them: They could have different dates as well as the need to be published individually.
The text was updated successfully, but these errors were encountered: