diff --git a/.eslintignore b/.eslintignore index 68f179b..bce97e3 100644 --- a/.eslintignore +++ b/.eslintignore @@ -1,3 +1,2 @@ -src/**/*.test.tsx src/**/*.spec.tsx **/node_modules/**/* diff --git a/.prettierignore b/.prettierignore index 15351c2..393280d 100644 --- a/.prettierignore +++ b/.prettierignore @@ -1,6 +1,4 @@ dist/ node_modules/ -**/*.css -**/*.scss **/*.md **/*.json diff --git a/packages/esm-admin-openconceptlab-app/package.json b/packages/esm-admin-openconceptlab-app/package.json index 6081081..c028ea5 100644 --- a/packages/esm-admin-openconceptlab-app/package.json +++ b/packages/esm-admin-openconceptlab-app/package.json @@ -2,7 +2,7 @@ "name": "@openmrs/esm-openconceptlab-app", "version": "4.0.3", "license": "MPL-2.0", - "description": "An app to manage the openconceptlab module", + "description": "Open Concept Lab management frontend module for O3", "browser": "dist/openmrs-esm-openconceptlab-app.js", "main": "src/index.ts", "source": true, diff --git a/packages/esm-admin-openconceptlab-app/src/import/import.component.tsx b/packages/esm-admin-openconceptlab-app/src/import/import.component.tsx index a03930e..03fe83b 100644 --- a/packages/esm-admin-openconceptlab-app/src/import/import.component.tsx +++ b/packages/esm-admin-openconceptlab-app/src/import/import.component.tsx @@ -23,13 +23,13 @@ const Import: React.FC = () => { const [file, setFile] = useState(); const [isFileUploading, setIsFileUploading] = useState(false); - const { data: subscription, isLoading, isError } = useSubscription(); + const { data: subscription, isLoading, error } = useSubscription(); useEffect(() => { - if (!isLoading && !isError) { + if (!isLoading && !error) { setIsSubscriptionAvailable(!!subscription); } - }, [isLoading, isError, subscription]); + }, [isLoading, error, subscription]); const onAddFiles = useCallback( (evt: React.DragEvent, { addedFiles }) => { @@ -138,7 +138,7 @@ const Import: React.FC = () => { ); } - if (isError) { + if (error) { showNotification({ kind: 'error', description: t('subscriptionError', 'Error occured while fetching the subscription'), diff --git a/packages/esm-admin-openconceptlab-app/src/import/import.resource.ts b/packages/esm-admin-openconceptlab-app/src/import/import.resource.ts index f7620f1..6d5cdb5 100644 --- a/packages/esm-admin-openconceptlab-app/src/import/import.resource.ts +++ b/packages/esm-admin-openconceptlab-app/src/import/import.resource.ts @@ -3,15 +3,15 @@ import useSWR from 'swr'; import type { Import, Subscription } from '../types'; export function useSubscription() { - const { data, error, isValidating } = useSWR<{ data: { results: Subscription[] } }, Error>( + const { data, error, isLoading, isValidating } = useSWR<{ data: { results: Subscription[] } }, Error>( '/ws/rest/v1/openconceptlab/subscription?v=full', openmrsFetch, ); return { data: data?.data?.results[0], - isLoading: !data && !error, - isError: error, + error, + isLoading, isValidating, }; } diff --git a/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.component.tsx b/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.component.tsx index 9b3cf48..4db6432 100644 --- a/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.component.tsx +++ b/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.component.tsx @@ -28,7 +28,7 @@ const PreviousImports: React.FC = () => { const { t } = useTranslation(); const [pageSize, setPageSize] = useState(10); - const { data: prevImports, isLoading, isError } = usePreviousImports(); + const { data: prevImports, isLoading, error } = usePreviousImports(); const { results, currentPage, goTo } = usePagination(prevImports, pageSize); if (isLoading) { @@ -43,7 +43,7 @@ const PreviousImports: React.FC = () => { ); } - if (isError) { + if (error) { showNotification({ kind: 'error', description: t('previousImportsFetchError', 'Error occured while fetching the imports'), @@ -76,7 +76,7 @@ const PreviousImports: React.FC = () => { return ( !isLoading && - !isError && ( + !error && (

{t('previousImports', 'Previous Imports')}

diff --git a/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.resource.ts b/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.resource.ts index cdd86d2..8ba811f 100644 --- a/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.resource.ts +++ b/packages/esm-admin-openconceptlab-app/src/previous-imports/previous-imports.resource.ts @@ -3,15 +3,15 @@ import useSWR from 'swr'; import type { Import } from '../types'; export function usePreviousImports() { - const { data, error, isValidating } = useSWR<{ data: { results: Import[] } }, Error>( + const { data, error, isLoading, isValidating } = useSWR<{ data: { results: Import[] } }, Error>( '/ws/rest/v1/openconceptlab/import?v=full', openmrsFetch, ); return { data: data?.data?.results, - isLoading: !data && !error, - isError: error, + error, + isLoading, isValidating, }; } diff --git a/packages/esm-admin-openconceptlab-app/src/subscription/subscription.component.tsx b/packages/esm-admin-openconceptlab-app/src/subscription/subscription.component.tsx index 5ad02b3..7a10f8e 100644 --- a/packages/esm-admin-openconceptlab-app/src/subscription/subscription.component.tsx +++ b/packages/esm-admin-openconceptlab-app/src/subscription/subscription.component.tsx @@ -30,17 +30,17 @@ const Subscription: React.FC = () => { const [validationType, setValidationType] = useState<'NONE' | 'FULL'>('FULL'); const [isSnapshotOptionDisabled, setIsSnapshotOptionDisabled] = useState(false); - const { data: subscription, isLoading, isError } = useSubscription(); + const { data: subscription, isLoading, error } = useSubscription(); useEffect(() => { - if (!isLoading && !isError) { + if (!isLoading && !error) { setSubscriptionUrl(subscription?.url || ''); setToken(subscription?.token || ''); setIsSubscribedToSnapshot(subscription?.subscribedToSnapshot || false); setValidationType(subscription?.validationType || 'FULL'); setIsSnapshotOptionDisabled(subscription ? isVersionDefinedInUrl(subscription.url) : false); } - }, [isLoading, isError, subscription]); + }, [isLoading, error, subscription]); const handleChangeSubscriptionUrl = useCallback((event: React.ChangeEvent) => { setSubscriptionUrl(event.target.value); @@ -189,7 +189,7 @@ const Subscription: React.FC = () => { ); } - if (isError) { + if (error) { showNotification({ kind: 'error', description: t('subscriptionError', 'Error occured while fetching the subscription'), diff --git a/packages/esm-admin-openconceptlab-app/src/subscription/subscription.resource.ts b/packages/esm-admin-openconceptlab-app/src/subscription/subscription.resource.ts index e5b7666..37a1ca5 100644 --- a/packages/esm-admin-openconceptlab-app/src/subscription/subscription.resource.ts +++ b/packages/esm-admin-openconceptlab-app/src/subscription/subscription.resource.ts @@ -4,15 +4,15 @@ import isNil from 'lodash-es/isNil'; import type { Subscription } from '../types'; export function useSubscription() { - const { data, error, isValidating } = useSWR<{ data: { results: Subscription[] } }, Error>( + const { data, error, isLoading, isValidating } = useSWR<{ data: { results: Subscription[] } }, Error>( '/ws/rest/v1/openconceptlab/subscription?v=full', openmrsFetch, ); return { data: data?.data?.results[0], - isLoading: !data && !error, - isError: error, + error, + isLoading, isValidating, }; } diff --git a/packages/esm-system-admin-app/package.json b/packages/esm-system-admin-app/package.json index 8944b6b..8a0b5fc 100644 --- a/packages/esm-system-admin-app/package.json +++ b/packages/esm-system-admin-app/package.json @@ -2,7 +2,7 @@ "name": "@openmrs/esm-system-admin-app", "version": "4.0.3", "license": "MPL-2.0", - "description": "System Admin page for OpenMRS", + "description": "System admin frontend module for O3", "browser": "dist/openmrs-esm-system-admin-app.js", "main": "src/index.ts", "source": true,