Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code specifying the location of Python source out of the .src (shell script) files. #27

Open
ttheimeroo opened this issue Jan 18, 2020 · 1 comment

Comments

@ttheimeroo
Copy link
Collaborator

ttheimeroo commented Jan 18, 2020

The script file Scraper_full_json.sh contains a conditional statement to set the location of Python for the host computer. This code is near line 22. There is similar code in Scraper_Twitter.sh.

Suggest to move this customization out of the code base and into a configuration file. The config file would not be included in a Git pull. A similar strategy would be to require that the host computer be set with an environmental variable or PATH stmt. The latter solution would be described in documentation. The goal is to ensure the the proper version of Python will be found in any new environment without modifying the project code base.

@hsmatis
Copy link
Contributor

hsmatis commented Jan 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants