-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version warning not appearing on ReadTheDocs for BODS v0.2.0 #81
Comments
I think answer is: BODS 0.2 Locks the theme to the commit before Amy's commit to fix this: 8b05124 Maybe if someone upgraded the locked version in 0.2 and hence let RTD rebuild the site it would be fine? Additional problem noticed while working on this: 0.2.0 locks version of the theme - good! https://github.com/openownership/data-standard/blob/0.2.0/requirements.txt#L8 0.3.0 does not! https://github.com/openownership/data-standard/blob/0.3.0/requirements.txt#L7 When did this happen? Looks like when we switched to compile tools? We need to sort this, and maybe this is something in favour of just merging the repositories? Moved to openownership/data-standard#459 |
Thanks for taking a look at this @rhiaro and @odscjames . |
Just checked and this has been resolved as of 0.4 - all versions are showing a warning message |
Actually this isn't resolved. There is a warning message showing on https://standard.openownership.org/en/0.2.0/schema/index.html But the warning message isn't showing on https://standard.openownership.org/en/0.2.0/index.html |
We've just release BODS v0.3.0.
When visiting v0.1.0 the version warning appears. When visiting v0.2.0 it doesn't appear.
@rhiaro did some work to enable the ReadTheDocs version banner within the site. Basically this added
role="main"
to a div at the top of the page. I can't see that role attribute on the div in the v0.2.0 page.@rhiaro - is there something else we need to do to make the banner appear? (Assigning to @odscjames too, since he's working on BODS atm and may be able to do the legwork if helpful.)
The text was updated successfully, but these errors were encountered: