-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listed company icon should show for listed companies #176
Comments
@kd-ods I have a fix which works for the data you've included above. However, I can't see what makes this a listed company in the BODS 0.4 example. The code checks for |
Ah!! Issue with the data. Thanks for picking that up. We'll fix that up in the data standard repo on this PR: openownership/data-standard#735 |
@codemacabre - this is some other BODS 0.4 data with a publicly listed company, for testing. |
@codemacabre - this isn't working on the demo/staking site atm. Should it be? |
@kd-ods Ah, looks like I built the demo site an hour-or-two before I fixed this issue so it's not on the demo site. I'll do a rebuild shortly. EDIT: Updated. Looks like it's working correctly now. |
@codemacabre - thanks! I can see it's working now. |
On the dev branch at the moment, pasting in this BODS 0.3 data:
erroneously shows as:
Instead of:
There is also a BODS 0.4 example that can be used to test a fix.
The text was updated successfully, but these errors were encountered: