Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listed company icon should show for listed companies #176

Closed
kd-ods opened this issue Nov 28, 2024 · 6 comments · Fixed by #175
Closed

Listed company icon should show for listed companies #176

kd-ods opened this issue Nov 28, 2024 · 6 comments · Fixed by #175
Assignees

Comments

@kd-ods
Copy link
Collaborator

kd-ods commented Nov 28, 2024

On the dev branch at the moment, pasting in this BODS 0.3 data:

[
  {
    "entityType": "legalEntity",
    "foundingDate": "1992-06-17T00:00:00+00:00",
    "identifiers": [
      {
        "id": "02723534",
        "scheme": "GB-COH"
      },
      {
        "id": "PY6ZZQWO2IZFZC3IOL08",
        "scheme": "XI-LEI"
      }
    ],
    "jurisdiction": {
      "code": "GB",
      "name": "United Kingdom of Great Britain and Northern Ireland (the)"
    },
    "isComponent": false,
    "name": "AstraZeneca PLC",
    "publicListing": {
      "hasPublicListing": true,
      "companyFilingsURLs": [
        "https://www.londonstockexchange.com/stock/AZN/astrazeneca-plc/analysis",
        "https://www.astrazeneca.com/investor-relations/stock-exchange-announcements.html"
      ],
      "securitiesListings": [
        {
          "marketIdentifierCode": "XLON",
          "operatingMarketIdentifierCode": "XLON",
          "security": {
            "idScheme": "isin",
            "id": "GB0009895292",
            "ticker": "AZN"
          },
          "stockExchangeJurisdiction": "GB",
          "stockExchangeName": "London Stock Exchange"
        },
        {
          "marketIdentifierCode": "XLOM",
          "operatingMarketIdentifierCode": "XLON",
          "security": {
            "idScheme": "isin",
            "id": "US0463531089",
            "ticker": "0A4J"
          },
          "stockExchangeJurisdiction": "GB",
          "stockExchangeName": "London Stock Exchange - MTF"
        },
        {
          "marketIdentifierCode": "XSTO",
          "operatingMarketIdentifierCode": "XSTO",
          "security": {
            "idScheme": "isin",
            "id": "GB0009895292",
            "ticker": "AZN"
          },
          "stockExchangeJurisdiction": "SE",
          "stockExchangeName": "NASDAQ Stockholm"
        },
        {
          "marketIdentifierCode": "XNAS",
          "operatingMarketIdentifierCode": "XNAS",
          "security": {
            "idScheme": "cusip",
            "id": "046353108",
            "ticker": "AZN"
          },
          "stockExchangeJurisdiction": "US",
          "stockExchangeName": "NASDAQ"
        }
      ]
    },
    "publicationDetails": {
      "bodsVersion": "0.3",
      "license": "https://creativecommons.org/licenses/by/2.0/legalcode",
      "publicationDate": "2021-02-09",
      "publisher": {
        "name": "Open Ownership",
        "url": "http://www.openownership.org"
      }
    },
    "source": {
      "description": "This information has been retrieved from diverse public sources.",
      "type": [
        "primaryResearch"
      ]
    },
    "statementDate": "2021-02-09",
    "statementID": "openo-es-00006565580581270044236",
    "statementType": "entityStatement"
  }
]

erroneously shows as:

Image

Instead of:

Image

There is also a BODS 0.4 example that can be used to test a fix.

@codemacabre
Copy link
Collaborator

@kd-ods I have a fix which works for the data you've included above.

However, I can't see what makes this a listed company in the BODS 0.4 example. The code checks for publicListing.hasPublicListing or recordDetails.publicListing.hasPublicListing, or defaults to the entityType which needs to be registeredEntityListed. The 0.4 example doesn't have any of that. Is this an issue with the data or is there another requirement for listed companies?

@codemacabre codemacabre moved this from Todo to In Progress in Visualisation 2024 Sprint 2 of 2 Nov 28, 2024
@kd-ods
Copy link
Collaborator Author

kd-ods commented Nov 28, 2024

Ah!! Issue with the data. Thanks for picking that up. We'll fix that up in the data standard repo on this PR: openownership/data-standard#735

@kd-ods
Copy link
Collaborator Author

kd-ods commented Nov 28, 2024

@codemacabre - this is some other BODS 0.4 data with a publicly listed company, for testing.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Dec 4, 2024

@codemacabre - this isn't working on the demo/staking site atm. Should it be?

@codemacabre
Copy link
Collaborator

codemacabre commented Dec 4, 2024

@kd-ods Ah, looks like I built the demo site an hour-or-two before I fixed this issue so it's not on the demo site. I'll do a rebuild shortly.

EDIT: Updated. Looks like it's working correctly now.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Dec 4, 2024

@codemacabre - thanks! I can see it's working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants