Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch from upstream LLVM to fix ssa value names for long integer constants #46

Open
mhillenbrand opened this issue Feb 14, 2023 · 1 comment

Comments

@mhillenbrand
Copy link
Contributor

For constant ops from arithmetic constants, MLIR chooses SSA value names that reflect the constant. That failed for ints with > 64 bits as the function that derived that name used a shortcut that did not apply (and assert(), as here) for ints with more than 64 bits.

We have contributed a fix to upstream LLVM in llvm/llvm-project@1ef32e7 and need to add this patch into our build of LLVM 14.0.6. (the fix will be included in LLVM 15).

Surfaced by #43

@vrpascuzzi
Copy link
Contributor

How is the CI passing? Locally, check-tests fails with current main (c941dd9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants