From 2e7e235fe6047a12720463d4a0e4f7408d3c8532 Mon Sep 17 00:00:00 2001 From: Miki Date: Tue, 1 Oct 2024 11:49:44 -0700 Subject: [PATCH] Fix duplicate i18n identifiers in visualize plugin (#8407) * Fix duplicate i18n identifiers in visualize plugin Signed-off-by: Miki * Changeset file for PR #8407 created/updated --------- Signed-off-by: Miki Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --- changelogs/fragments/8407.yml | 2 ++ .../public/application/components/visualize_listing.tsx | 4 ++-- .../public/application/components/visualize_top_nav.tsx | 2 +- .../public/application/utils/get_top_nav_config.tsx | 8 ++++---- 4 files changed, 9 insertions(+), 7 deletions(-) create mode 100644 changelogs/fragments/8407.yml diff --git a/changelogs/fragments/8407.yml b/changelogs/fragments/8407.yml new file mode 100644 index 000000000000..27029ebbe418 --- /dev/null +++ b/changelogs/fragments/8407.yml @@ -0,0 +1,2 @@ +fix: +- Fix duplicate i18n identifiers in visualize plugin ([#8407](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8407)) \ No newline at end of file diff --git a/src/plugins/visualize/public/application/components/visualize_listing.tsx b/src/plugins/visualize/public/application/components/visualize_listing.tsx index 17ddd2c7bfe5..b904bdfe1b00 100644 --- a/src/plugins/visualize/public/application/components/visualize_listing.tsx +++ b/src/plugins/visualize/public/application/components/visualize_listing.tsx @@ -89,7 +89,7 @@ export const VisualizeListing = () => { if (showUpdatedUx) { chrome.setBreadcrumbs([ { - text: i18n.translate('visualize.visualizeListingBreadcrumbsTitle', { + text: i18n.translate('visualize.listingBreadcrumbsTitle', { defaultMessage: 'Visualizations', }), }, @@ -97,7 +97,7 @@ export const VisualizeListing = () => { } else { chrome.setBreadcrumbs([ { - text: i18n.translate('visualize.visualizeListingBreadcrumbsTitle', { + text: i18n.translate('visualize.legacy.listingBreadcrumbsTitle', { defaultMessage: 'Visualize', }), }, diff --git a/src/plugins/visualize/public/application/components/visualize_top_nav.tsx b/src/plugins/visualize/public/application/components/visualize_top_nav.tsx index f1c47016d048..e2bc639e79f0 100644 --- a/src/plugins/visualize/public/application/components/visualize_top_nav.tsx +++ b/src/plugins/visualize/public/application/components/visualize_top_nav.tsx @@ -261,7 +261,7 @@ const TopNav = ({ indexPatterns={indexPatterns} screenTitle={ vis.title || - i18n.translate('discover.savedSearch.newTitle', { + i18n.translate('visualize.savedSearch.newTitle', { defaultMessage: 'New visualization', }) } diff --git a/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx b/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx index cffd251b3eb4..78d1dbb07a30 100644 --- a/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx +++ b/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx @@ -106,7 +106,7 @@ export const getLegacyTopNavConfig = ( { id: 'inspector', label: i18n.translate('visualize.topNavMenu.openInspectorButtonLabel', { - defaultMessage: 'inspect', + defaultMessage: 'Inspect', }), description: i18n.translate('visualize.topNavMenu.openInspectorButtonAriaLabel', { defaultMessage: 'Open Inspector for visualization', @@ -127,7 +127,7 @@ export const getLegacyTopNavConfig = ( { id: 'share', label: i18n.translate('visualize.topNavMenu.shareVisualizationButtonLabel', { - defaultMessage: 'share', + defaultMessage: 'Share', }), description: i18n.translate('visualize.topNavMenu.shareVisualizationButtonAriaLabel', { defaultMessage: 'Share Visualization', @@ -168,10 +168,10 @@ export const getLegacyTopNavConfig = ( label: savedVis?.id && originatingApp ? i18n.translate('visualize.topNavMenu.saveVisualizationAsButtonLabel', { - defaultMessage: 'save as', + defaultMessage: 'Save as', }) : i18n.translate('visualize.topNavMenu.saveVisualizationButtonLabel', { - defaultMessage: 'save', + defaultMessage: 'Save', }), emphasize: (savedVis && !savedVis.id) || !originatingApp, description: i18n.translate('visualize.topNavMenu.saveVisualizationButtonAriaLabel', {