[Proposal] [query-assistant] Move query assistant feature to dashboards-assistant plugin

[ruanyl]

Overview

This proposal suggests migrating the recently added Query Assistant feature from the core query-enhancement plugin to the dashboards-assistant plugin.

Reason

As the dashboards-assistant plugin is intended to serve as a central hub for OSD AI-related functionalities, consolidating the Query Assistant feature within this plugin will provide several benefits:

1. By grouping all AI-related features and APIs under a single plugin, we can reduce the maintenance efforts, ensuring consistent API contracts across all AI functionalities.
2. Users will have a single, clear location to find all AI-driven enhancements. This will improve the discoverability and usability of these features.
3. Moving the feature to a dedicated plugin reduces the complexity of the core query-enhancement plugin. This can help reduce potential dependencies between plugins.

Plan

1. Migrate and refactor the current query-assistant feature in core query_enhancement plugin to dashboards-assistant plugin.
2. Remove the query-assistant feature related implementations in core.
3. Make sure this change is clearly communicated across stakeholders: @joshuali925 @kavilla @ashwin-pc

Question

1. How to deal with the query-assistant feature in Observability plugin?

[joshuali925]

i think this makes sense, it would basically be moving this registration and related components to dashboards-assistant plugin

OpenSearch-Dashboards/src/plugins/query_enhancements/public/plugin.tsx

Lines 106 to 110 in 461a395

	data.__enhance({
	editor: {
	queryEditorExtension: createQueryAssistExtension(core.http, data, this.config.queryAssist),
	},
	});

and i agree with the benefit this brings.

How to deal with the query-assistant feature in Observability plugin?

For now I would prefer to keep Observability plugin as is with mostly maintenance changes, and we should encourage users to use Discover for query assist. If in the future there are plans to integrate with more plugins, maybe dashboards-assistant can expose the query assist component or some hooks to interact with ML-Commons agent for other plugins to consume, and we can see if it would be easier to refactor Observability plugin to use those.