Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "master" terminology in Log message #2539

Closed
tlfeng opened this issue Mar 21, 2022 · 1 comment · Fixed by #2575
Closed

Replace "master" terminology in Log message #2539

tlfeng opened this issue Mar 21, 2022 · 1 comment · Fixed by #2575
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Severity-Blocker v2.0.0 Version 2.0.0

Comments

@tlfeng
Copy link
Collaborator

tlfeng commented Mar 21, 2022

Is your feature request related to a problem? Please describe.

With the issue #472, "master" terminology is going to be replaced by "cluster manager" to promote inclusive language.
"master" terminology in log messages have not be changed yet.

The log message means the String-type message defined by log4j.Logger, such as in logger.info(), or logger.warn().

Some keywords in the log messages are:

master is discovered
master not discovered
master node
master-eligible
as master
elected-as-master

For example ,there are 3 consecutive log messages contain "master" during a node start up without any configuration in opensearch.yml:

[2022-03-21T11:29:55,117][INFO ][o.o.c.c.ClusterBootstrapService] [ip-172-00-00-000] no discovery configuration found, will perform best-effort cluster bootstrapping after [3s] unless existing master is discovered
[2022-03-21T11:29:55,162][INFO ][o.o.c.s.MasterService ] [ip-172-00-00-000] elected-as-master ([1] nodes joined)[{ip-172-00-00-000}{EW9xY5H-TmisjI03i45_VA}{EPvDlgLmRHS6FzfdUu4NPw}{127.0.0.1}{127.0.0.1:9300}{dimr}{shard_indexing_pressure_enabled=true} elect leader, BECOME_MASTER_TASK, FINISH_ELECTION], term: 2, version: 4, delta: master node changed {previous [], current [{ip-172-31-15-168}{EW9xY5H-TmisjI03i45_VA}{EPvDlgLmRHS6FzfdUu4NPw}{127.0.0.1}{127.0.0.1:9300}{dimr}{shard_indexing_pressure_enabled=true}]}
[2022-03-21T11:29:55,198][INFO ][o.o.c.s.ClusterApplierService] [ip-172-00-00-000] master node changed {previous [], current [{ip-172-00-00-000}{EW9xY5H-TmisjI03i45_VA}{EPvDlgLmRHS6FzfdUu4NPw}{127.0.0.1}{127.0.0.1:9300}{dimr}{shard_indexing_pressure_enabled=true}]}, term: 2, version: 4, reason: Publication{term=2, version=4}

Describe the solution you'd like
Replace master to cluster-manager in the log messages.

Describe alternatives you've considered
none.

Additional context
Related to issue #1548 if the log message doesn't impact backwards compatibility.

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request untriaged v2.0.0 Version 2.0.0 Severity-Blocker and removed untriaged labels Mar 21, 2022
@owaiskazi19 owaiskazi19 self-assigned this Mar 25, 2022
@tlfeng
Copy link
Collaborator Author

tlfeng commented Mar 28, 2022

Resolved in the commit cc0e66b / PR #2575. The backport PRs are #2593 and #2594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Severity-Blocker v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants