Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Names don't adhere to plugin naming convention #209

Closed
Tracked by #174
mnkugler opened this issue Nov 30, 2022 · 4 comments
Closed
Tracked by #174

[BUG] Names don't adhere to plugin naming convention #209

mnkugler opened this issue Nov 30, 2022 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@mnkugler
Copy link

What is the bug?
As per https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md#opensearch-plugins, the folder name needs to adhere to the naming convention

What is the expected behavior?
Folder needs to be created and Include full plugin name in kebab case, e.g., plugins/opensearch-asynchronous-search

Do you have any additional context?
Referred to here:
opensearch-project/opensearch-plugins#174

@mnkugler mnkugler added bug Something isn't working untriaged labels Nov 30, 2022
@Arpit-Bandejiya Arpit-Bandejiya added enhancement New feature or request and removed untriaged labels Jan 20, 2023
@mnkugler
Copy link
Author

mnkugler commented Apr 6, 2023

Hi @Arpit-Bandejiya . Noticed you are assign to this issue. Can you provide a status update on resolving this?

@Arpit-Bandejiya
Copy link
Collaborator

Hi, the build file is in the root directory and this is a core opensearch plugin and I see that other core plugins are following the same convention: https://github.com/opensearch-project/cross-cluster-replication, https://github.com/opensearch-project/security . @mnkugler can you please explain the ask and the prerequisite for the change for a plugin?

@Arpit-Bandejiya
Copy link
Collaborator

Also we are following the naming convention in the build.gradle here: https://github.com/opensearch-project/asynchronous-search/blob/main/build.gradle#LL148C22-L148C34

@Arpit-Bandejiya
Copy link
Collaborator

Closing the issue since I don't think there is anything to be changed. Pleae re-open if there are any concerns thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants