Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Names don't adhere to plugin naming convention #99

Closed
mnkugler opened this issue Nov 30, 2022 · 2 comments
Closed

[BUG] Names don't adhere to plugin naming convention #99

mnkugler opened this issue Nov 30, 2022 · 2 comments
Assignees

Comments

@mnkugler
Copy link

mnkugler commented Nov 30, 2022

As per https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md#plugin-naming-conventions,

Plugin ID needs to be lowercase camelcase

Meta needs to be updated to match the plugin name

Also, as per opensearch-project/opensearch-build#2188, we should get rid of the folder and move opensearch_dashboards.json to the root folder of the repo.

Referred to here:
opensearch-project/opensearch-plugins#174

@junqiu-lei
Copy link
Member

Hi @mnkugler, I think we resolved all the issues you mentioned, could you help check? Thanks!

Plugin ID needs to be lowercase camelcase

we uses customImportMapDashboards at opensearch_dashboards.json

Meta needs to be updated to match the plugin name

opensearch-project/opensearch-plugins#195 merged to resolved it

we should get rid of the folder and move opensearch_dashboards.json to the root folder of the repo.

Yes, it's under repo root path

@mnkugler
Copy link
Author

Hi @junqiu-lei -- everything looks good. Thanks for resolving all the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants