Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Stylelint #630

Open
2 tasks
BSFishy opened this issue Jul 11, 2023 · 2 comments · May be fixed by #634
Open
2 tasks

Onboard Stylelint #630

BSFishy opened this issue Jul 11, 2023 · 2 comments · May be fixed by #634

Comments

@BSFishy
Copy link

BSFishy commented Jul 11, 2023

OSD provides CSS linting through Stylelint and the yarn lint:style command. This helps maintain code quality and code style. Additionally, we're trying to move towards no custom styling, which means no Sass files. We're pushing this out incrementally, and right now we are pushing to remove custom colors and font overrides. To accurately locate these issues, the Stylelint output needs to be clean. However, this is currently not the case.

2 things need to happen for this:

  • Add script to run Stylelint and add it to the build and test workflow
  • Fix any issues that Stylelint currently throws
@BSFishy
Copy link
Author

BSFishy commented Jul 11, 2023

I'd like to take on this work

This was referenced Jul 11, 2023
@ps48
Copy link
Member

ps48 commented Jul 12, 2023

@BSFishy Does this mean, any dashboards plugin cannot override the css elements for OUI components? If so, what's the rationale behind this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants