From a479d7809f3674a71d21ba718c6a3fcde075caa8 Mon Sep 17 00:00:00 2001 From: Adam Tackett Date: Fri, 13 Sep 2024 14:40:36 -0700 Subject: [PATCH 1/2] ui adjustments Signed-off-by: Adam Tackett --- .../components/app_table.tsx | 4 +- .../components/application.tsx | 4 - .../components/configuration.tsx | 15 +- .../__snapshots__/note_table.test.tsx.snap | 8 +- .../__snapshots__/notebook.test.tsx.snap | 160 ++++++++++-------- .../notebooks/components/note_table.tsx | 5 +- .../notebooks/components/notebook.tsx | 89 ++++++---- .../overview/components/card_configs.tsx | 4 +- public/plugin_helpers/plugin_nav.tsx | 6 +- 9 files changed, 163 insertions(+), 132 deletions(-) diff --git a/public/components/application_analytics/components/app_table.tsx b/public/components/application_analytics/components/app_table.tsx index 3c9fc3f9b..0b99a60d0 100644 --- a/public/components/application_analytics/components/app_table.tsx +++ b/public/components/application_analytics/components/app_table.tsx @@ -10,7 +10,6 @@ import { EuiFieldSearch, EuiFlexGroup, EuiFlexItem, - EuiHorizontalRule, EuiInMemoryTable, EuiLink, EuiLoadingSpinner, @@ -236,7 +235,7 @@ export function AppTable(props: AppTableProps) { )} - + @@ -261,7 +260,6 @@ export function AppTable(props: AppTableProps) { - {filteredApplications.length > 0 ? ( { return ( <> - { return ( <> - - diff --git a/public/components/application_analytics/components/configuration.tsx b/public/components/application_analytics/components/configuration.tsx index b45a42f44..aa115d038 100644 --- a/public/components/application_analytics/components/configuration.tsx +++ b/public/components/application_analytics/components/configuration.tsx @@ -36,14 +36,7 @@ interface ConfigProps { } export const Configuration = (props: ConfigProps) => { - const { - appId, - application, - parentBreadcrumbs, - visWithAvailability, - updateApp, - switchToAvailability, - } = props; + const { appId, application, visWithAvailability, updateApp, switchToAvailability } = props; const [availabilityVisId, setAvailabilityVisId] = useState( application.availability.availabilityVisId || '' ); @@ -57,11 +50,11 @@ export const Configuration = (props: ConfigProps) => {
- + - -

Configuration details

+ +

Configuration details

 diff --git a/public/components/notebooks/components/__tests__/__snapshots__/note_table.test.tsx.snap b/public/components/notebooks/components/__tests__/__snapshots__/note_table.test.tsx.snap index ddff08348..16f6a5490 100644 --- a/public/components/notebooks/components/__tests__/__snapshots__/note_table.test.tsx.snap +++ b/public/components/notebooks/components/__tests__/__snapshots__/note_table.test.tsx.snap @@ -21,7 +21,7 @@ exports[` spec renders the component 1`] = `
@@ -190,8 +190,8 @@ exports[` spec renders the component 1`] = `
-
spec renders the empty component 1`] = `
diff --git a/public/components/notebooks/components/__tests__/__snapshots__/notebook.test.tsx.snap b/public/components/notebooks/components/__tests__/__snapshots__/notebook.test.tsx.snap index 90ebce72d..f2213e48f 100644 --- a/public/components/notebooks/components/__tests__/__snapshots__/notebook.test.tsx.snap +++ b/public/components/notebooks/components/__tests__/__snapshots__/notebook.test.tsx.snap @@ -29,74 +29,86 @@ exports[` spec Renders the empty component 1`] = `
- + + +
- + + +
- + + +
spec Renders the visualization component 1`] = `
- + + +
)} - + {newNavigation ? ( - + { {this.state.savedObjectNotebook ? ( <> - + + } + > + + - + + } + > + + - + + } + > + + ) : ( <> - + + } + > + + )} diff --git a/public/components/overview/components/card_configs.tsx b/public/components/overview/components/card_configs.tsx index b4969bf2b..9fa5f2f2a 100644 --- a/public/components/overview/components/card_configs.tsx +++ b/public/components/overview/components/card_configs.tsx @@ -31,7 +31,7 @@ const GETTING_STARTED_CONFIG: GettingStartedConfig = { defaultMessage: 'Set up your Observability workspace', }), description: 'Get started by collecting and analyzing your metrics, logs, and traces.', - footer: 'Getting Started Guide', + footer: 'Get started', url: observabilityGettingStartedID, path: '#/', }; @@ -46,7 +46,7 @@ const SAMPLEDATA_CONFIG: GettingStartedConfig = { defaultMessage: 'Try OpenSearch', }), url: tutorialSampleDataPluginId, - footer: 'Sample Datasets', + footer: 'Sample datasets', path: '#/', }; diff --git a/public/plugin_helpers/plugin_nav.tsx b/public/plugin_helpers/plugin_nav.tsx index 36c1ab2d3..75e8e021b 100644 --- a/public/plugin_helpers/plugin_nav.tsx +++ b/public/plugin_helpers/plugin_nav.tsx @@ -53,7 +53,7 @@ export function registerAllPluginNavGroups(core: CoreSetup Date: Mon, 16 Sep 2024 09:10:55 -0700 Subject: [PATCH 2/2] update getting started card footer Signed-off-by: Adam Tackett --- public/components/overview/components/card_configs.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/components/overview/components/card_configs.tsx b/public/components/overview/components/card_configs.tsx index 9fa5f2f2a..9ddcfcf5f 100644 --- a/public/components/overview/components/card_configs.tsx +++ b/public/components/overview/components/card_configs.tsx @@ -31,7 +31,7 @@ const GETTING_STARTED_CONFIG: GettingStartedConfig = { defaultMessage: 'Set up your Observability workspace', }), description: 'Get started by collecting and analyzing your metrics, logs, and traces.', - footer: 'Get started', + footer: 'Getting started guide', url: observabilityGettingStartedID, path: '#/', };