From 67ee569c0cf3074fc540b50cc28ecb63ec954bf8 Mon Sep 17 00:00:00 2001 From: Danila Gulderov Date: Tue, 5 Mar 2024 09:06:35 +0300 Subject: [PATCH] Fix eslint errors Signed-off-by: Danila Gulderov --- .../components/context_menu/context_menu.js | 37 ++++++++++++------- .../context_menu/context_menu_ui.js | 5 ++- 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/public/components/context_menu/context_menu.js b/public/components/context_menu/context_menu.js index 1afe449a..bc20bd7c 100644 --- a/public/components/context_menu/context_menu.js +++ b/public/components/context_menu/context_menu.js @@ -175,16 +175,20 @@ $(function () { $(document).on('click', '#generateCSV', function () { const timeRanges = getTimeFieldsFromUrl(); const queryUrl = replaceQueryURL(location.href); - const saved_search_id = getUuidFromUrl()[1]; - generateInContextReport(timeRanges, queryUrl, 'csv', { saved_search_id }); + const savedSearchId = getUuidFromUrl()[1]; + generateInContextReport(timeRanges, queryUrl, 'csv', { + saved_search_id: savedSearchId, + }); }); // generate XLSX onclick $(document).on('click', '#generateXLSX', function () { const timeRanges = getTimeFieldsFromUrl(); const queryUrl = replaceQueryURL(location.href); - const saved_search_id = getUuidFromUrl()[1]; - generateInContextReport(timeRanges, queryUrl, 'xlsx', { saved_search_id }); + const savedSearchId = getUuidFromUrl()[1]; + generateInContextReport(timeRanges, queryUrl, 'xlsx', { + saved_search_id: savedSearchId, + }); }); // navigate to Create report definition page with report source and pre-set time range @@ -237,8 +241,8 @@ $(function () { }); /* generate a report if flagged in URL params */ -const checkURLParams = async () => { - const [hash, query] = location.href.split('#')[1].split('?'); +async function checkURLParams() { + const [hash, query] = location.href.split('#')[1]?.split('?'); const params = new URLSearchParams(query); const id = params.get(GENERATE_REPORT_PARAM); if (!id) return; @@ -258,7 +262,7 @@ const checkURLParams = async () => { } finally { $('#reportGenerationProgressModal').remove(); } -}; +} const isDiscoverNavMenu = (navMenu) => { return ( @@ -284,7 +288,7 @@ const isVisualizationNavMenu = (navMenu) => { }; function locationHashChanged() { - const observer = new MutationObserver(function (mutations) { + const observer = new MutationObserver(function () { const navMenu = document.querySelectorAll( 'nav.euiHeaderLinks > div.euiHeaderLinks__list' ); @@ -300,6 +304,7 @@ function locationHashChanged() { return; } const menuItem = document.createElement('div'); + // eslint-disable-next-line no-unsanitized/property menuItem.innerHTML = getMenuItem( i18n.translate('opensearch.reports.menu.name', { defaultMessage: 'Reporting', @@ -322,7 +327,7 @@ function locationHashChanged() { }); } -$(window).one('hashchange', function (e) { +$(window).one('hashchange', function () { locationHashChanged(); }); /** @@ -343,10 +348,16 @@ window.onpopstate = history.onpushstate = () => { locationHashChanged(); }; -const getApiPath = () => { - if (window.location.href.includes('/data-explorer/discover/')) return '../../../api' - if (window.location.href.includes('/data-explorer/discover')) return '../../api' - return '../api' +function getApiPath() { + if (window.location.href.includes('/data-explorer/discover/')) { + return '../../../api'; + } + + if (window.location.href.includes('/data-explorer/discover')) { + return '../../api'; + } + + return '../api'; } async function getTenantInfoIfExists() { diff --git a/public/components/context_menu/context_menu_ui.js b/public/components/context_menu/context_menu_ui.js index 49eaf36b..bf42a2ac 100644 --- a/public/components/context_menu/context_menu_ui.js +++ b/public/components/context_menu/context_menu_ui.js @@ -192,7 +192,10 @@ export const popoverMenuDiscover = (savedObjectAvailable) => { <${button} class="${buttonClass}" type="button" data-test-subj="downloadPanel-GeneratePDF" id="generateXLSX"> - ${i18n.translate('opensearch.reports.menu.csv.generateXLSX', { defaultMessage: 'Generate XLSX' })} + ${i18n.translate( + 'opensearch.reports.menu.csv.generateXLSX', + { defaultMessage: 'Generate XLSX' } + )}