Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jar names for Data Prepper plugins #4931

Open
dlvenable opened this issue Sep 10, 2024 · 0 comments
Open

Improve jar names for Data Prepper plugins #4931

dlvenable opened this issue Sep 10, 2024 · 0 comments
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

Data Prepper plugins have Gradle module names such as opensearch, common, kafka-plugins`, etc. These are good in Gradle. But, in the Docker image (and eventually on Maven), these names can be confusing.

In particular, I noticed this with the opensearch-2.9.0 jar file. I thought this was OpenSearch 2.9.0. This also caused vulnerability scans to detect that this had a vulnerability which is valid for OpenSearch 2.9.0, not Data Prepper's opensearch sink/source.

docker run opensearchproject/data-prepper:2.9.0 ls /usr/share/data-prepper/lib/opensearch-2.9.0.jar
/usr/share/data-prepper/lib/opensearch-2.9.0.jar

Running a jar listing reveals that this is Data Prepper's opensearch plugin.

docker run opensearchproject/data-prepper:2.9.0 jar tvf /usr/share/data-prepper/lib/opensearch-2.9.0.jar | grep Sink
  3406 Wed Aug 28 15:35:36 UTC 2024 org/opensearch/dataprepper/plugins/sink/opensearch/OpenSearchSinkConfiguration.class
 47509 Wed Aug 28 15:35:36 UTC 2024 org/opensearch/dataprepper/plugins/sink/opensearch/OpenSearchSink.class

Describe the solution you'd like

I'd like to rename the jar files that Data Prepper produces to start all Data Prepper plugins with data-prepper-plugin-.

At the same time, I'd like to keep the module names in Gradle the same. We can configure Gradle to change the way it produces output to help with this.

@dlvenable dlvenable added untriaged maintenance Issues to help maintain the project, such as improving builds, testing, etc. and removed untriaged labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Development

No branches or pull requests

1 participant