Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement BedrockRerank[Pre|Post]ProcessFunction #3254

Open
tkykenmt opened this issue Dec 5, 2024 · 5 comments · May be fixed by #3339 or #3352
Open

[FEATURE] Implement BedrockRerank[Pre|Post]ProcessFunction #3254

tkykenmt opened this issue Dec 5, 2024 · 5 comments · May be fixed by #3339 or #3352
Assignees
Labels
enhancement New feature or request v2.19.0 Issues targeting release v2.19.0

Comments

@tkykenmt
Copy link
Contributor

tkykenmt commented Dec 5, 2024

Is your feature request related to a problem?

Amazon Bedrock introduced Rerank model support. OpenSearch can invoke Rerank models on Bedrock by writing custom pre/post processing function, but pre-built function is good for performance.

What solution would you like?
Implement BedrockRerankPreProcessing and BedrockRerankPostProcessing based on existing processor functions as follows.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@ylwu-amzn
Copy link
Collaborator

@tkykenmt , Do you want to implement this ?

@tkykenmt
Copy link
Contributor Author

@ylwu-amzn Yes, I'd like to implement this.

@ylwu-amzn ylwu-amzn added the v2.19.0 Issues targeting release v2.19.0 label Dec 24, 2024
@ylwu-amzn
Copy link
Collaborator

@tkykenmt , we plan to release this in the coming 2.19 , code freeze January 28th, 2025 . Do you have enough bandwidth to implement this and merge before the code freeze date ?

@tkykenmt
Copy link
Contributor Author

tkykenmt commented Jan 4, 2025

@ylwu-amzn
Thank you for following-up. I'm implementing it and will create PR before freeze date on 2.19.

tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 4, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 6, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 6, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 6, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 6, 2025
@dblock dblock removed the untriaged label Jan 6, 2025
@dblock
Copy link
Member

dblock commented Jan 6, 2025

[Catch All Triage - 1, 2, 3, 4, 5, 6]

tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 7, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 7, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 7, 2025
tkykenmt added a commit to tkykenmt/ml-commons that referenced this issue Jan 9, 2025
@dhrubo-os dhrubo-os moved this to In Progress in ml-commons projects Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.19.0 Issues targeting release v2.19.0
Projects
Status: In Progress
3 participants