Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IntegTests autocuts will remove labels but will not close issues if no test failed #4799

Closed
peterzhuamazon opened this issue Jun 23, 2024 · 5 comments

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jun 23, 2024

[BUG] IntegTests autocuts will remove labels but will not close issues if no test failed #4799
opensearch-project/asynchronous-search#584

Thanks.

@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Jun 23, 2024
@getsaurabh02
Copy link
Member

getsaurabh02 commented Jun 23, 2024

Should it add a comment also around not failing from last run timestamp?

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jun 23, 2024

I think the logic is supposed to be:

  1. If test failed and no issue open, open the issue and add related distro label.
  2. if test succeed later then remove that related distro label.
  3. If all failed distribution labels are removed due to integTests passing, close issue.

Right now it seems only removing the labels but not closing even when there is no failed distro/label.

Thanks.

@prudhvigodithi
Copy link
Collaborator

Hey @peterzhuamazon thats the expected behavior as of today, I have created an issue regrading this topic in past, please check this issue #4495.
Thanks

@peterzhuamazon
Copy link
Member Author

Got it @prudhvigodithi , closing this one in favor of the old issue:

Thanks.

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants