You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two copies of the entry are passed it, this can lead to passing the old for new bugs
This is needed for optimistic locking which requires the current state of the document, by passing the full entry it includes the sequence number and the shard id which are both needed.
If there components were put into a different object type like ETag for the second parameter it would prevent passing the wrong parameter into the function call. I think we do need to clean this up - but lets attack this in future revisions.
In calls like
Two copies of the entry are passed it, this can lead to passing the old for new bugs
This is needed for optimistic locking which requires the current state of the document, by passing the full entry it includes the sequence number and the shard id which are both needed.
If there components were put into a different object type like
ETag
for the second parameter it would prevent passing the wrong parameter into the function call. I think we do need to clean this up - but lets attack this in future revisions.Originally posted by @peternied in #693 (comment)
The text was updated successfully, but these errors were encountered: