Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add version bump instructions for OpenSearch Dashboards plugins #136

Open
abhinavGupta16 opened this issue Apr 5, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@abhinavGupta16
Copy link

What is the bug?
The version bump does not work fully for dashboard plugins. The .json files for example are not edited with the sed commands - https://github.com/opensearch-project/opensearch-plugins/blob/main/META.md#increment-version-in-plugins

For example - https://github.com/opensearch-project/alerting-dashboards-plugin/blob/main/opensearch_dashboards.json https://github.com/opensearch-project/observability/blob/main/dashboards-observability/package.json needs to be updated when the version is bumped.

How can one reproduce the bug?
Execute the https://github.com/opensearch-project/opensearch-plugins/blob/main/META.md#increment-version-in-plugins for dashboard plugins

What is the expected behavior?
All version is bumped correctly in all the required files

@abhinavGupta16 abhinavGupta16 added bug Something isn't working untriaged labels Apr 5, 2022
@dblock dblock removed the untriaged label Apr 11, 2022
@dblock
Copy link
Member

dblock commented Apr 11, 2022

These instructions were only for OpenSearch plugins, not OpenSearch Dashboards :) I should have made that clearer. Renaming this issue to support OSD plugins.

@dblock dblock changed the title [BUG] Version bump is not done correctly for dashboard plugins [BUG] Add version bump instructions for OpenSearch Dashboards plugins Apr 11, 2022
@dblock dblock added enhancement New feature or request and removed bug Something isn't working labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants