Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Extract output from previous Tool #137

Open
xinyual opened this issue Jan 18, 2024 · 2 comments
Open

[FEATURE] Extract output from previous Tool #137

xinyual opened this issue Jan 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@xinyual
Copy link
Collaborator

xinyual commented Jan 18, 2024

Is your feature request related to a problem?
Now in flow agent and chat agent, tool would be hard to fetch previous tools' output because

  1. in flow agent, the key in parameters map would be "<tool_name>.output" and tool_name is defined by customer. So we cannot config this in java code. We need one-more customer defined field like add previous key for PPL tool #131
  2. In chat agent, the previous output would be dropped. Only the action_input of this round will be used.

What solution would you like?

  1. Extract the field and method inside add previous key for PPL tool #131 into an abstract class implements Tool. Then each tool should extend this abstract Tool
  2. A map should be kept inside the runReAct function to store all "<tool_name>: <tool_output>" pairs
@xinyual xinyual added enhancement New feature or request untriaged labels Jan 18, 2024
@xinyual
Copy link
Collaborator Author

xinyual commented Jan 18, 2024

@ylwu-amzn Could you please check this issue to see whether we need to do so? Also, if we build the abstract Tool class, the method to load default prompt like #125 could be also put into it.

@dblock
Copy link
Member

dblock commented Jun 17, 2024

@ylwu-amzn ^

Catch All Triage - 1 2 3 4 5

@dblock dblock removed the untriaged label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants