Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a shortname to imagecontentsourcepolicy #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide a shortname to imagecontentsourcepolicy #623

wants to merge 1 commit into from

Conversation

bmillemathias-1a
Copy link

@bmillemathias-1a bmillemathias-1a commented Apr 7, 2020 •
edited
Loading

This is really boring to type this long name so often as a sysadmin.
Saving people from typing 20 letters x N times a day makes me happy.
Not sure this is as easy as adding this single line,

Please if you could back-port that to any release downward to 4.3.

fixes #622

@bmillemathias-1a
Provide a shortname to imagecontentsourcepolicy
2bdd753 
Save people from typing 20 x N times makes me happy.
Not sure this is easy as this single line,

fixes openshift#622
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmillemathias-1a
To complete the pull request process, please assign jwforres
You can assign the PR to them by writing /assign @jwforres in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Hi @bmillemathias-1a. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2020
@bmillemathias-1a
Copy link
Author

/assign @jwforres

@bmillemathias
Copy link

any feedback on this ?

@jwforres jwforres removed their assignment Jul 21, 2020
@jwforres
Copy link
Member

@mrunalp was an api short name proposed at all for icsp's?

@mrunalp
Copy link
Member

mrunalp commented Jul 22, 2020

@jwforres Not when we first added it IIRC, but icsp sounds good since that's what everyone uses to refer to it.

@bmillemathias
Copy link

@jwforres Not when we first added it IIRC, but icsp sounds good since that's what everyone uses to refer to it.

any update to get this merged ?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2021
@bmillemathias
Copy link

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 3, 2021
@bmillemathias
Copy link

Hello @mrunalp
Any update on this considering this is a tiny patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imagecontentsourcepolicy has no shortname
6 participants
@bmillemathias-1a @openshift-ci-robot @bmillemathias @jwforres @mrunalp @openshift-bot