Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate Charm Store vcs-revisions Field #26

Open
dshcherb opened this issue Apr 3, 2018 · 0 comments
Open

Populate Charm Store vcs-revisions Field #26

dshcherb opened this issue Apr 3, 2018 · 0 comments

Comments

@dshcherb
Copy link
Contributor

dshcherb commented Apr 3, 2018

Having repo-info is a nice way to preserve commit hash information (

echo " + Generating repo info and adding as $charm_dir/repo-info"
./generate-repo-info $charm_dir > $charm_dir/repo-info
echo "$(cat $charm_dir/repo-info | sed -e 's/^/ /')"
), however, there is another place where we could add this metadata.

When 'charm push' is invoked, it tries to obtain commit information based on vcs-specific dot files in the current directory. For classic charms this seems to happen automatically as they are not pre-processed, for reactive this is not the case as they are built into a separate directory that does not contain a dot-file.

https://git.io/vxPvs

Example:
charm show cs:keystone --all

...
extra-info:
  vcs-revisions:
  - authors:
    - email: corey.bryant@[email protected]
      name: Corey Bryant
    commit: 3a4faf4df4794b6031b49079b2c56309a3578a7f
    date: 2018-03-12T14:15:26-04:00
    message: |-
      Update SSL/https documentation
...
      Change-Id: I2e0140f909ef2c57182895f37cf191b6bc80157b
      Closes-Bug: #1754682
      (cherry picked from commit 3384ddcb87a2c7621719c8844cf5a24a25936d48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants