Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BGP_DT01] Enable octavia #338

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[BGP_DT01] Enable octavia #338

merged 1 commit into from
Oct 24, 2024
+77 −1

Conversation

eduolivares
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from abays and cjeanner July 19, 2024 07:51
@eduolivares eduolivares marked this pull request as draft July 19, 2024 07:53
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c1fb95568a8c4eadbe151eb01a2de73c

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2120 is needed.

@eduolivares
Copy link
Contributor Author

recheck

@eduolivares eduolivares force-pushed the bgp+octavia branch 2 times, most recently from 3ae684b to dbeb3f7 Compare September 18, 2024 12:31
@eduolivares eduolivares marked this pull request as ready for review October 23, 2024 07:37
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2120 is needed.

@eduolivares
Copy link
Contributor Author

recheck

@eduolivares eduolivares added testing-complete Testing is completed and ready for final reviews ready-review Request is ready to be reviewed labels Oct 23, 2024
abays
abays approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 24, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, eduolivares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aa41a51bba07421c847a583a7e9820b6

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bgp SUCCESS in 3m 27s
✔️ rhoso-architecture-validate-bgp_dt01 SUCCESS in 3m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 65b46e3 into openstack-k8s-operators:main Oct 24, 2024
7 checks passed
@eduolivares eduolivares deleted the bgp+octavia branch October 24, 2024 08:31
@eduolivares
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot
Copy link

@eduolivares: new pull request created: #424

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@cjeanner cjeanner Awaiting requested review from cjeanner

@leifmadsen leifmadsen Awaiting requested review from leifmadsen

Assignees

@abays abays

Labels
approved lgtm ready-review Request is ready to be reviewed testing-complete Testing is completed and ready for final reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduolivares @openshift-cherrypick-robot @abays