Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically show refreshing icon on the dictionaries widget #1331

Open
user202729 opened this issue May 22, 2021 · 0 comments · May be fixed by #1400
Open

Dynamically show refreshing icon on the dictionaries widget #1331

user202729 opened this issue May 22, 2021 · 0 comments · May be fixed by #1400

Comments

@user202729
Copy link
Member

user202729 commented May 22, 2021

Is your feature request related to a problem? Please describe.

Related to the issue I raised on the Plover Python dictionary last time.

Sometimes some dictionaries are slower to load than the others, and it would be useful to have a visual indicator to know which one is slow.

Describe the solution you'd like

Make Plover show the "refreshing" state for only the actually-loading dictionaries on startup, instead of all of them.

Currently if a single dictionary is added, only that one has the refreshing state, which is desired. But on startup the refreshing icon only disappear when all dictionaries finished loading.


Implementation note: This might need some refactoring, because currently there's only the dictionaries_loaded hook triggered when all the dictionaries are loaded.

It's possible to trigger the hook when not all dictionaries are loaded, but (it breaks backward compatibility and) currently the hook is triggered inside engine, it would require some changes.

@user202729 user202729 changed the title Dynamically update Dynamically show refreshing icon on the DictionariesWidget May 22, 2021
@user202729 user202729 changed the title Dynamically show refreshing icon on the DictionariesWidget Dynamically show refreshing icon on the dictionaries widget May 22, 2021
@user202729 user202729 linked a pull request Aug 3, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants