Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgimap recipe for dev: switch to cmake #1018

Closed
mmd-osm opened this issue Jan 7, 2024 · 4 comments
Closed

cgimap recipe for dev: switch to cmake #1018

mmd-osm opened this issue Jan 7, 2024 · 4 comments

Comments

@mmd-osm
Copy link

mmd-osm commented Jan 7, 2024

CGImap has moved to cmake yesterday, i.e. the old autotools based build steps in https://github.com/openstreetmap/chef/blob/8e86bcdcde5541c466540d6a9f908b17fc9c4884/cookbooks/dev/recipes/default.rb#L449-L465 no longer work.

Instead of running autogen.sh and configure, it should be sufficient to create a new build directory in the repo's main directory, and then run cmake .. from there. make -j should then work as usual, assuming cmake .. didn't report any issues.

Hopefully, no extra parameters like "--with-fcgi=/usr --with-boost-libdir=/usr/lib/x86_64-linux-gnu --enable-yajl" are needed anymore. YAJL is enabled by default, and cmake should be able to figure out on its own where fcgi and boost libraries are located.

Thanks for looking into this!

@tomhughes
Copy link
Member

tomhughes commented Jan 7, 2024

Fixed in openstreetmap/chef@730fadf.

@mmd-osm
Copy link
Author

mmd-osm commented Jan 9, 2024

I committed this change zerebubuth/openstreetmap-cgimap@81e6a3a to include the current build timestamp in the generator string (e.g. "CGImap 0.8.10.2401091705 ..."). The idea was to see more easily when changes made it to faffy without manually bumping the version number every time.

On faffy I still see the previous "0.8.10" in the generator string w/o the build timestamp: https://master.apis.dev.openstreetmap.org/api/0.6/node/4317965188 .

I can't really figure out if the build is failing for some reason, or if there's some other issue with the new cmake set up.

@tomhughes
Copy link
Member

It had rebuilt, just not restarted. Fixed in openstreetmap/chef@844fb4d.

@mmd-osm
Copy link
Author

mmd-osm commented Jan 9, 2024

Thanks a lot for the quick fix, looking good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants