You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Background
With the parameter enableKeepPartialLinestring enabled, the linestring of a way is generated even if the way is incomplete. This geometry is - as per the definition - different from the original geometry. The implementation is (shortly said) that every non-existing node is simply skipped. This normally doesn't change the nature of the way, it is just "shortened" or "shrunk" a little bit. (In rare cases the linestring can become an invalid geometry. All as expected)
Problem
However, for a closed way where the first (= last) node is missing, this changes the geometry such that a closed way (which can be polygonized) suddenly becomes an open way. An example would be to take way https://www.openstreetmap.org/way/1059958114 from the extract of Zeeland generated here: http://download.openstreetmap.fr/extracts/europe/netherlands/ . This partially downloaded (closed) way generates the following (open) linestring
Request
When calling Osmosis with enableKeepPartialLinestring enabled, verify whether the id of the first node of the original way was identical to the id of the last node of the original way. (The references to the node ID should still be in the way object, even if some of the nodes themselves are missing). If this is the case, close the partial line string by "adding" the first node to the end of the linestring.
Maybe this should be the default for enableKeepPartialLinestring=yes, or maybe it's better to add a third option for enableKeepPartialLinestring (like enableKeepPartialLinestring="keepClosed").
Background
With the parameter
enableKeepPartialLinestring
enabled, the linestring of a way is generated even if the way is incomplete. This geometry is - as per the definition - different from the original geometry. The implementation is (shortly said) that every non-existing node is simply skipped. This normally doesn't change the nature of the way, it is just "shortened" or "shrunk" a little bit. (In rare cases the linestring can become an invalid geometry. All as expected)Problem
However, for a closed way where the first (= last) node is missing, this changes the geometry such that a closed way (which can be polygonized) suddenly becomes an open way. An example would be to take way https://www.openstreetmap.org/way/1059958114 from the extract of Zeeland generated here: http://download.openstreetmap.fr/extracts/europe/netherlands/ . This partially downloaded (closed) way generates the following (open) linestring
Request
When calling Osmosis with
enableKeepPartialLinestring
enabled, verify whether the id of the first node of the original way was identical to the id of the last node of the original way. (The references to the node ID should still be in the way object, even if some of the nodes themselves are missing). If this is the case, close the partial line string by "adding" the first node to the end of the linestring.Maybe this should be the default for
enableKeepPartialLinestring=yes
, or maybe it's better to add a third option for enableKeepPartialLinestring (likeenableKeepPartialLinestring="keepClosed"
).cc @frodrigo
The text was updated successfully, but these errors were encountered: