Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Find styles" button is not looking into userstyles.world #1777

Open
vitaly-zdanevich opened this issue May 14, 2024 · 16 comments
Open

Comments

@vitaly-zdanevich
Copy link

Website: https://verbum.by

The userstyle: https://userstyles.world/style/14978/verbum-by-black-amoled

Screenshot 2024-05-15 at 00 25 15

@tophf
Copy link
Member

tophf commented May 14, 2024

Style's category is verbum.by, belarus, dictionary, which is treated as a single value that doesn't match the category of the site verbum.by. While we can show styles for such comma-separated category, but strictly speaking it's not the intended usage of this field, it's not "tags".

@vednoc, what do you think?

@pabuisson
Copy link

Not sure if I should go on in this thread, but I'm having the same question.

What are the mandatory fields to have a style hosted on userstyles.world available in Stylus search or what would make a style hosted on userstyles.world not findable in Stylus? Is this described explicitely somewhere? Userstyles.world FAQ only mentions the category.

@tophf
Copy link
Member

tophf commented May 25, 2024

A correct category is the only necessary thing.

@pabuisson
Copy link

Thanks for your reply @tophf! I'm sorry to be that guy, but do you have any clue why this style would not show up in stylus?

  • it has a category that I think is valid,
  • it's been online for a few days,
  • and I still can't see it when I'm searching from Stylus.

Let me know if you would like me to open a separate issue for this.

@tophf
Copy link
Member

tophf commented May 25, 2024

The category is just lichess for common domains like com or org.

@pabuisson
Copy link

pabuisson commented May 25, 2024

The category is just lichess for common domains like com or org.

Wow. Thanks for the quick reply again, I would not have guessed that. Is there somewhere you think this could be documented (wiki?) to avoid this kind of issues? I'm happy to create it if you want.

Maybe the FAQ: https://github.com/openstyles/stylus/wiki/FAQ ?

@tophf
Copy link
Member

tophf commented May 25, 2024

It might make more sense to suggest adding this info in userstyles.world. I guess it was implicitly expected that authors would look at the other styles that are shown in the popup and copy their category.

@pabuisson
Copy link

It might make more sense to suggest adding this info in userstyles.world. I guess it was implicitly expected that authors would look at the other styles that are shown in the popup and copy their category.

That's what I did but the ~10 styles I looked up where not hosted on userstyles.world, unfortunately. Anyway thanks and I'll ping the people over at userstyles.world to see what can be done!

@tophf
Copy link
Member

tophf commented May 25, 2024

The popup shows two sources and the category is the same in both. You probably assumed that lichess displayed in the style has the same meaning as lichess.org.

@vitaly-zdanevich
Copy link
Author

This style is not found in dropdown manu, with correct category habr.com https://userstyles.world/style/14797/habr-com-black

@tophf
Copy link
Member

tophf commented May 26, 2024

No, the category should be just the site's name (habr) for common domains like com or org. You can inspect other styles that are shown in the menu and see their category.

@vitaly-zdanevich
Copy link
Author

Hm, they should update this text?
image

@vitaly-zdanevich
Copy link
Author

I changed Category from habr.com to habr but still not found.

@tophf
Copy link
Member

tophf commented May 27, 2024

Your style is shown here now. Apparently it takes some time to update the index.

they should update this text?

Yep.

@vitaly-zdanevich
Copy link
Author

Apparently it takes some time to update the index.

Yep I see it now.

@vednoc
Copy link
Member

vednoc commented Jul 1, 2024

@vednoc, what do you think?

Hi @tophf! I would rather keep category as is and add support for proper tags, which we will also use in USw's search. That's one of the things I experimented with adding before going on multiple long breaks. It might take a while for me to implement them due to the sheer number of other things, but we could discuss it in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants