Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing an Add-on Instance #40

Open
Unichron opened this issue Apr 4, 2023 · 2 comments
Open

Installing an Add-on Instance #40

Unichron opened this issue Apr 4, 2023 · 2 comments
Assignees

Comments

@Unichron
Copy link

Unichron commented Apr 4, 2023

Issue on page: https://github.com/opentelekomcloud-docs/cloud-container-engine/blob/main/api-ref/source/apis/add-on_management/installing_an_add-on_instance.rst

The addon .spec.values object is missing the "flavor" parameter (next to basic and custom). This is for configuring replica count and resource requests/limits of the addons. I think the impacted pages are installing and updating (if it's possible to update, haven't checked).

@oeotvos
Copy link
Contributor

oeotvos commented Apr 5, 2023

Hi, /api/v3/addontemplates returns the information of how request body during specific addon creation should look like. The flavor and also other parameters are not described because every addon can have different parameters.
The API reference contains examples (e.g. Updating an Add-on) with usage of the flavor.

Anyway, thank you for your remark, we will definitely update the add-on spec field description with the most common parameters like flavor, etc. and make a usage of this API more obvious.

example of coredns creation:
{
"kind": "Addon",
"apiVersion": "v3",
"metadata": {
"annotations": {
"addon.install/type": "install"
}
},
"spec": {
"clusterID": "cf59fc4a-cfb8-11ed-89cc-02550a10004e",
"version": "1.25.1",
"addonTemplateName": "coredns",
"values": {
"basic": {},
"custom": {
"stub_domains": "",
"upstream_nameservers": ""
},
"flavor": {
"description": "Has only one instance",
"name": "Single",
"replicas": 1,
"resources": [
{
"limitsCpu": "100m",
"limitsMem": "128Mi",
"name": "coredns",
"requestsCpu": "100m",
"requestsMem": "128Mi"
}
]
}
}
}
}

(Internal demand opened #CONT-1578)

@oeotvos oeotvos self-assigned this Nov 16, 2023
@oeotvos
Copy link
Contributor

oeotvos commented Nov 21, 2023

Internal demand OTCPR-5601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants