Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] RMS #468

Closed
wants to merge 6 commits into from
Closed

[NEW] RMS #468

wants to merge 6 commits into from

Conversation

Aloento
Copy link
Member

@Aloento Aloento commented Nov 16, 2022 •
edited
Loading

fix #438

@Aloento Aloento added enhancement New feature or request need acceptance Requires running acceptance tests (including cases requiring admin role) labels Nov 16, 2022
@Aloento Aloento self-assigned this Nov 16, 2022
anton-sidelnikov
anton-sidelnikov requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@anton-sidelnikov anton-sidelnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tests please

openstack/rms/v1/resources/ListResources.go Outdated Show resolved Hide resolved
openstack/rms/v1/resources/ListResources.go Outdated Show resolved Hide resolved
gtema
gtema requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no implementation for enterpriseProjectID - this is not present/enabled in OTC - and will not be

@Aloento Aloento marked this pull request as draft November 16, 2022 13:22
@Aloento Aloento removed their assignment Jul 23, 2024
@anton-sidelnikov
Copy link
Member

Will close it, because new service published instead of old rms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov requested changes

@gtema gtema gtema requested changes

@artem-lifshits artem-lifshits Awaiting requested review from artem-lifshits artem-lifshits will be requested when the pull request is marked ready for review artem-lifshits is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request need acceptance Requires running acceptance tests (including cases requiring admin role)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW] Resource Management Service
3 participants
@Aloento @anton-sidelnikov @gtema