Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat.] DirectConnect V3 implementation #719

Merged
merged 6 commits into from
Oct 21, 2024
Merged

[Feat.] DirectConnect V3 implementation #719

merged 6 commits into from
Oct 21, 2024

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Sep 19, 2024 •
edited
Loading

What this PR does / why we need it

Customer asked support new services within terraform

Which issue this PR fixes

Closes #720

Special notes for your reviewer

=== RUN   TestHostedConnectLifecycle
    hosted_connect_test.go:35: Attempting to create DCaaSv3 hosted connect
    hosted_connect_test.go:39: Attempting to retrieve list of DCaaSv3 hosted connects
    hosted_connect_test.go:44: Attempting to retrieve DCaaSv3 hosted connect: 01437c7e-a5a2-4c71-b184-9c7217a3c703
    hosted_connect_test.go:49: Attempting to update DCaaSv3 hosted connect: 01437c7e-a5a2-4c71-b184-9c7217a3c703
    hosted_connect_test.go:59: Attempting to delete DCaaSv3 hosted connect: 01437c7e-a5a2-4c71-b184-9c7217a3c703
--- PASS: TestHostedConnectLifecycle (3.95s)
PASS

=== RUN   TestVirtualGatewayListing
--- PASS: TestVirtualGatewayListing (0.55s)
PASS

Process finished with the exit code 0

=== RUN   TestVirtualGatewayLifecycle
    virtual_gateway_test.go:44: Attempting to create DCaaSv3 virtual gateway
    virtual_gateway_test.go:62: Attempting to obtain DCaaSv3 virtual gateway: d6614129-82ec-4444-8668-6ef5310bf34e
    virtual_gateway_test.go:67: Attempting to update DCaaSv3 virtual gateway: d6614129-82ec-4444-8668-6ef5310bf34e
    virtual_gateway_test.go:77: Attempting to obtain list of DCaaSv3 virtual gateways: d6614129-82ec-4444-8668-6ef5310bf34e
    virtual_gateway_test.go:85: Attempting to delete DCaaSv3 virtual gateway: d6614129-82ec-4444-8668-6ef5310bf34e
--- PASS: TestVirtualGatewayLifecycle (2.70s)
PASS

Process finished with the exit code 0

=== RUN   TestVirtualInterfaceListing
--- PASS: TestVirtualInterfaceListing (0.74s)
PASS

Process finished with the exit code 0

=== RUN   TestVirtualInterfaceLifecycle
    virtual_interface_test.go:49: Attempting to create DCaaSv3 virtual gateway
    virtual_interface_test.go:71: Attempting to create DCaaSv3 virtual interface
    virtual_interface_test.go:89: Attempting to obtain DCaaSv3 virtual interface: d98cab65-321b-473d-83b2-0b6c071493d9
    virtual_interface_test.go:94: Attempting to update DCaaSv3 virtual interface: d98cab65-321b-473d-83b2-0b6c071493d9
    virtual_interface_test.go:103: Attempting to obtain list of DCaaSv3 virtual interfaces
    virtual_interface_test.go:109: Attempting to delete DCaaSv3 virtual interface: d98cab65-321b-473d-83b2-0b6c071493d9
--- PASS: TestVirtualInterfaceLifecycle (6.13s)
PASS

Process finished with the exit code 0

@anton-sidelnikov anton-sidelnikov added the need acceptance Requires running acceptance tests (including cases requiring admin role) label Sep 20, 2024
@anton-sidelnikov anton-sidelnikov self-assigned this Sep 20, 2024
@anton-sidelnikov anton-sidelnikov marked this pull request as ready for review October 21, 2024 11:40
@anton-sidelnikov anton-sidelnikov added enhancement New feature or request and removed need acceptance Requires running acceptance tests (including cases requiring admin role) labels Oct 21, 2024
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Oct 21, 2024
@otc-zuul otc-zuul bot merged commit e793177 into devel Oct 21, 2024
8 checks passed
@otc-zuul otc-zuul bot deleted the dc-v3 branch October 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@Aloento Aloento Awaiting requested review from Aloento

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

@muneeb-jan muneeb-jan Awaiting requested review from muneeb-jan

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New DirectConnect V3 services
2 participants
@anton-sidelnikov @artem-lifshits