Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_coldkeypub arguments passed in wrong order #51

Open
adal-chiriliuc-reef opened this issue Oct 13, 2024 · 0 comments
Open

set_coldkeypub arguments passed in wrong order #51

adal-chiriliuc-reef opened this issue Oct 13, 2024 · 0 comments

Comments

@adal-chiriliuc-reef
Copy link

adal-chiriliuc-reef commented Oct 13, 2024 •
edited
Loading

Method called with overwrite=overwrite, encrypt=false, but the method accepts these two arguments in the other order - encrypt first, then overwrite:

https://github.com/opentensor/btwallet/blob/main/src/wallet.rs#L831

self.set_coldkeypub(keypair, overwrite, false, py)?;

https://github.com/opentensor/btwallet/blob/main/src/wallet.rs#L515-L521

pub fn set_coldkeypub(
    &mut self,
    keypair: Keypair,
    encrypt: bool,
    overwrite: bool,
    py: Python,
) -> PyResult<()> {
camfairchild added a commit that referenced this issue Nov 5, 2024
@camfairchild
closes GH #51
40555a3
@camfairchild camfairchild mentioned this issue Nov 5, 2024
Merged
camfairchild added a commit that referenced this issue Nov 6, 2024
@camfairchild
closes GH #51 (#56)
f43e625
roman-opentensor added a commit that referenced this issue Nov 7, 2024
@roman-opentensor @ibraheem-opentensor @camfairchild
[fix] Use user home directory for wallet path (#59)
f420553 
* Updates local -> environment vars in changelog

* closes GH #51 (#56)

* [fix] Use userhome for default wallet path ~ (#57)

* use userhome for default path ~

* bump ver

* expand path on init and use as _path

---------

Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
camfairchild added a commit that referenced this issue Nov 12, 2024
@thewhaleking @roman-opentensor
@ibraheem-opentensor @camfairchild
Release 2.1.0 (#61)
bd5ed7d 
* add PasswordError and bound to python

* formatter

* add `from bittensor_wallet.errors import PasswordError`

* return encrypted password, remove debug

* [fix] Use user home directory for wallet path (#59)

* Updates local -> environment vars in changelog

* closes GH #51 (#56)

* [fix] Use userhome for default wallet path ~ (#57)

* use userhome for default path ~

* bump ver

* expand path on init and use as _path

---------

Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>

* Fix ruff (#62)

* add rustup to CI (#63)

* add rustup to CI

* make rustup accept all

* add to path

* Update CHANGELOG.MD

* Update CHANGELOG.MD

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
camfairchild added a commit that referenced this issue Nov 12, 2024
@camfairchild @roman-opentensor @ibraheem-opentensor
Release 2.1.0 (#65)
f41da22 
* add PasswordError and bound to python

* formatter

* add `from bittensor_wallet.errors import PasswordError`

* return encrypted password, remove debug

* [fix] Use user home directory for wallet path (#59)

* Updates local -> environment vars in changelog

* closes GH #51 (#56)

* [fix] Use userhome for default wallet path ~ (#57)

* use userhome for default path ~

* bump ver

* expand path on init and use as _path

---------

Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>

* Fix ruff (#62)

* add rustup to CI (#63)

* add rustup to CI

* make rustup accept all

* add to path

* Update CHANGELOG.MD

* Update CHANGELOG.MD

* fix changelog

* bump ver

* bump cargo toml ver

* Update CHANGELOG.MD

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
unconst pushed a commit that referenced this issue Nov 22, 2024
@camfairchild @roman-opentensor
@ibraheem-opentensor @distributedstatemachine
Release 2.1.0 (#65)
7ee5d57 
* add PasswordError and bound to python

* formatter

* add `from bittensor_wallet.errors import PasswordError`

* return encrypted password, remove debug

* [fix] Use user home directory for wallet path (#59)

* Updates local -> environment vars in changelog

* closes GH #51 (#56)

* [fix] Use userhome for default wallet path ~ (#57)

* use userhome for default path ~

* bump ver

* expand path on init and use as _path

---------

Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>

* Fix ruff (#62)

* add rustup to CI (#63)

* add rustup to CI

* make rustup accept all

* add to path

* Update CHANGELOG.MD

* Update CHANGELOG.MD

* fix changelog

* bump ver

* bump cargo toml ver

* Update CHANGELOG.MD

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adal-chiriliuc-reef