Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing implementation of preprocess function in 272-paint-by-example.ipynb notebook #1579

Closed
anujonthemove opened this issue Dec 26, 2023 · 3 comments · Fixed by #1646
Closed
Assignees
Labels
bug Something isn't working PSE Escalate to PSE for further investigate

Comments

@anujonthemove
Copy link

I was going through the code in the notebook: 272-paint-by-example.ipynb, I could not find the implementation of preprocess function used in the prepare_latents method of the class OVStableDiffusionInpaintingPipeline

image

This is definitely missing. Please look into it.

@Iffa-Intel
Copy link

Hi @anujonthemove

I managed to run the notebook:

image

The only thing that I need to modify is the grdio version: %pip install gradio==3.50.2
Once installed, restart kernel & run the cells.

@anujonthemove
Copy link
Author

Thanks for getting back to me. Yes, I know that the notebook works fine with gradio version 3.50.2 because the latest versions don't have the sketch tool for the Image component yet.

Just wanted to point out that the notebook doesn't have the preprocess function, but it still runs smoothly. The reason is that the process_latent function wraps up just before preprocess kicks in, so it doesn't impact anything.

I noticed the same thing in the 236-stable-diffusion-v2-infinite-zoom.ipynb notebook. On the flip side, the 225-stable-diffusion-text-to-image.ipynb notebook has it sorted.

If needed, I can fix it, double-check, and send in a pull request.

@Iffa-Intel Iffa-Intel added the PSE Escalate to PSE for further investigate label Dec 28, 2023
@avitial
Copy link

avitial commented Jan 2, 2024

@anujonthemove please submit your changes in a pull request and we can discuss your proposed changes there. Refer to https://github.com/openvinotoolkit/openvino/blob/master/CONTRIBUTING.md for guidelines.

@avitial avitial self-assigned this Jan 2, 2024
@eaidova eaidova linked a pull request Jan 24, 2024 that will close this issue
@avitial avitial added bug Something isn't working and removed support_request labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PSE Escalate to PSE for further investigate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants