Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeBWorK 3 backend to-do list #110

Open
4 of 13 tasks
drdrew42 opened this issue Aug 7, 2022 · 3 comments
Open
4 of 13 tasks

WeBWorK 3 backend to-do list #110

drdrew42 opened this issue Aug 7, 2022 · 3 comments

Comments

@drdrew42
Copy link
Member

drdrew42 commented Aug 7, 2022

  • [PS] refactor relationships for plural/singular relation names
  • [PS] update all instances of validation to use new Validation.pm
  • use ->insert wherever ->new(...) is used for row creation
  • add fetch_with_defaults as an alias for discard_changes and employ everywhere add_to_$rel is used
  • [PS] eliminate dependency on List::MoreUtils (firstval)
  • [AP] update all $self to use more appropriate naming convention
  • [GR] switch tests in t/db to use Test2::V0
  • [AP] Instead of throwing errors on fields not in the DB, filter out non-existent fields. This is done in ResultSet::UserSet::addUserSet
  • [PS] DeleteXXXX in ResultSet classes should return 200 OK and the tests should check to make sure that the XXX was deleted.
  • resolve UserProblem problem_version (nullable with default value?) add uniqueness on user+problem+version
  • Attempt field comments is a JSON column?
  • Include a created_date and updated_date field in each table
  • Uniformize test checking of boolean fields (and update DB to ensure proper booleans on create/update/fetch)
@drdrew42
Copy link
Member Author

drdrew42 commented Aug 7, 2022

@pstaabp @drgrice1 feel free to add to this checklist 🙏

@pstaabp
Copy link
Member

pstaabp commented Aug 9, 2022

I just edited the list above.

@drdrew42
Copy link
Member Author

drdrew42 commented Aug 10, 2022

discard_changes is no longer needed now that we've added retrieve_on_insert => 1 to all columns with default values. Please keep this in mind for any future DB changes that involve default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants