Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-lua-runtime/luci-base: luci menu cache issue [23.05] #6528

Open
jjm2473 opened this issue Aug 21, 2023 · 5 comments
Open

luci-lua-runtime/luci-base: luci menu cache issue [23.05] #6528

jjm2473 opened this issue Aug 21, 2023 · 5 comments

Comments

@jjm2473
Copy link
Contributor

jjm2473 commented Aug 21, 2023

After wifi module auto configured, menu not shown "Wireless". Same issue appears on Docker, if I open luci on browser on boot, Docker maybe not start on that time, menu will not show Docker menu even after docker started.

rm -f /tmp/luci-indexcache* drop the cache resolv that.

@jjm2473
Copy link
Contributor Author

jjm2473 commented Aug 21, 2023

In the previous version, for the lua controller, the lua code was cached, not the menu.

@jow-
Copy link
Contributor

jow- commented Aug 22, 2023

I'm afraid that the caching is something I won't roll back, constantly rebuilding the menu and synchronizing it with the client is just too much work, but maybe we can figure out a smarter way for cache invalidation.

@jjm2473
Copy link
Contributor Author

jjm2473 commented Aug 22, 2023

I use this patch to force outdate cache after 5 seconds jjm2473@a430de5

May still cause performance impact on low-performance platforms.

@jjm2473
Copy link
Contributor Author

jjm2473 commented Aug 22, 2023

I suggest lua controller cache code, and the json menu add dependencies to the calculation of cache hash

@wryun
Copy link
Contributor

wryun commented Apr 12, 2024

See #6422 (dupe?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants