Add configuration to support MD5 auth with bird2 #1088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix openwrt#1084 Signed-off-by: Guillaume Perrin <[email protected]>
|
So this adds a dependency on the kmod package? Isn't that a little overkill to have as a hard dependency? It's perfectly possible to use bird without that.
How many extra packages does it pull in when installing bird on a fresh install after this change?
|
I haven’t found the kmod that allows to load this functionality but if there is one then this PR is useless.
I truly don’t know how to find that number. As I already say I do the same thin they do for FRR, so I thought that was the right say to do it. |
|
On 16 November 2024 00:13:25 CET, Guillaume Perrin ***@***.***> wrote:
> So this adds a dependency on the kmod package? Isn't that a little overkill to have as a hard dependency? It's perfectly possible to use bird without that.
I haven’t found the kmod that allows to load this functionality but if there is one then this PR is useless.
If it's not a kmod, what does this patch do, exactly? AFAOU, bird and the kernel aren't built together, so how does setting a kconfig option in a package Makefile work, exactly?
> How many extra packages does it pull in when installing bird on a fresh install after this change?
I truly don’t know how to find that number
I would just install the package and see what dependencies it pulls in with and without this patch...
|
|
Do you want something like this? |
|
Yes this is probably a better way to do it that what I purpose and what has been done in FRR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @tohojo
Compile tested: x86-64, generic, snapshot
Run tested: x86-64, generic, snapshot
Description:
Fix #1084
Same correction as in FRR openwrt/packages#24178