feat: improve yurthub configmap management #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambohe-ch
force-pushed
the
improve-yurthub-config
branch
from
d5faecc to
78c2933
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2275 +/- ##
==========================================
- Coverage 45.41% 45.36% -0.06%
==========================================
Files 427 427
Lines 29185 29105 -80
==========================================
- Hits 13255 13204 -51
+ Misses 14614 14586 -28
+ Partials 1316 1315 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
force-pushed
the
improve-yurthub-config
branch
from
78c2933 to
9b8756e
Compare
Signed-off-by: rambohe-ch <[email protected]>
rambohe-ch
force-pushed
the
improve-yurthub-config
branch
from
9b8756e to
1417968
Compare
|
|
/LGTM @rambohe-ch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a new manager named configuration manager in yurthub for managing
kube-system/yurt-hub-cfgconfigmap, and provide functions for cache manager and filter approver.There is no change of API, it means this pull request is transparent to end users. and this pull request can make the code more readable and maintainable. the efficiency of yurthub is also improved.
The removal of cache should be managed by gc when cache agents configuration is changed. now this feature is not supported.
Which issue(s) this PR fixes:
Fixes #2274
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note