Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace query parameter by anchor in dynamicaly generated pages #107

Open
benoit74 opened this issue Apr 30, 2024 · 0 comments
Open

Replace query parameter by anchor in dynamicaly generated pages #107

benoit74 opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement New feature or request priority 2 Medium priority
Milestone

Comments

@benoit74
Copy link
Collaborator

See #106 (comment)

In all dynamically generated pages like "unavailable_offline", we use query strings to indicate dynamic values that has to be used in the page.

This is now known to me to be a bad idea. It only works due to kiwix-serve dropping the query parameter before transferring the request to libzim. This is known to have issues in other readers.

The queryparameter must be replaced by a magic anchor.

@benoit74 benoit74 added the enhancement New feature or request label Apr 30, 2024
@benoit74 benoit74 added this to the 0.4.0 milestone Apr 30, 2024
@benoit74 benoit74 added the priority 2 Medium priority label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority 2 Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant