Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic to list what needs to be retrieved #33

Closed
benoit74 opened this issue Apr 15, 2022 · 0 comments · Fixed by #34
Closed

Simplify logic to list what needs to be retrieved #33

benoit74 opened this issue Apr 15, 2022 · 0 comments · Fixed by #34

Comments

@benoit74
Copy link
Collaborator

In order to avoid too complex logic, for every type of item (category, guide, wiki, item, user, team, ...) we will always:

  • retrieve the list of items to scrape from the API, not from already fetched items (i.e. the list of guides to retrieve will come from the API, not from the guides found while scraping categories) ; this will ensure that we grab all known items, no matter if we have an error while processing another item
  • allow a by-pass for every items by specifying exact items to be processed on the command line
  • don't care about non-browsability (i.e. if you ask to retrieve a sub-category while its parent is not scraped, we don't care); browsability is anyway ensured by the full text search + the future sitemap (see Generate a sitemap, accessible from the homepage #12 )
  • handle "unexpected" items separately, i.e. items we discovered while scraping other items, and retrieve them ; they will be listed for reporting at the end of the scrape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant