Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFixit ZIM in French has articles in English #84

Open
kelson42 opened this issue Jun 19, 2022 · 3 comments
Open

IFixit ZIM in French has articles in English #84

kelson42 opened this issue Jun 19, 2022 · 3 comments
Labels
bug Something isn't working question Further information is requested stale

Comments

@kelson42
Copy link
Contributor

kelson42 commented Jun 19, 2022

Many articles (most of them?) are in English.

Thi is is a problem because:

  • This is not what was requested by user
  • Most users can not deal with them
  • Files are artificially big
@kelson42 kelson42 added the bug Something isn't working label Jun 19, 2022
@benoit74
Copy link
Collaborator

This is done "on purpose", but is maybe not the best decision that has been made 😄

The main reason it is done this way is that most stuff is only available in English. If we do not include non-local items for non-English archives, the archive begins to be rather difficult to navigate. One way to navigate is to go from top categories down to your device category, choose the appropriate guide and open it. If some category on this path has not been translated, then the browsing chain will be broken.

I see two alternatives:

  • consider that it is a price to pay, and that broken navigation is acceptable since it would allow to reduce most archives sizes dramatically. And maybe in many cases, when there is a guide that has been translated, its parent categories have probably been translated as well (not sure at all about this assumption)
  • consider that the bulk size of the archive is the guides, and continue to archive all categories in all languages but store only the guides of the requested language

In both cases, it means that we will have some broken links which cannot be detected "in advance" by the scraper, so we will replace them by a redirect to an "error page" stating that this item is not yet available in the current language.

@kelson42 @rgaudin : does any of this makes any sense for you?

@kelson42
Copy link
Contributor Author

@benoit74 Thx for the explanation. For the moment I propose to keep this ticket open to let things maturing a bit.

@kelson42 kelson42 added the question Further information is requested label Jun 22, 2022
@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

2 participants